Does not add subscribtions at all..[fixed ?]
patchak - July 31, 2007 - 10:29
| Project: | Simplenews Roles |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Hey there,
I installed this module so I could easily send a mail to all the members of my site. I added the simplenews role module so that I could easily subscribe all the members of my site... I checked the role (authenticated user) that I wanted to automatically add, but nothing happens.
No error appears, but the subscriptions simply does not work, as no users were added to the list of subscribded members... I'm using the latest version of this module and of simplenews, with drupal 5.1...
It would be really nice to have this module working...
Thanks for any tips and help you can give me,
Patchak
#1
Installed the same versions as you and fired it up today myself. It removed the subscriptions I already had so now I have no subscribers to my newsletter. :)
It works with a custom role (admin) that I made though. So the error is probably caused by "authenticated user" not actually being listed as a role in the users list.
#2
Hummm, ok.. I'll try with a custom role, but I think that it should work with authenticated user as well?? Is this a bug? I think so...
#3
I confirm this as a bug. I fortunately only had 25 users and one newsletter, and was able to manually add all of them by appending values to the simplenews_tid_snid table (or whatever it is called) - I had tried to use the role 'authenticated user' and instead of subscribing them all it removed all of them! No matter what I did, it wanted to kill all the subscriptions. I have uninstalled the module for now - probably there is a single line of code that I could hack to fix it. Too bad - this is very useful, potentially.
#4
Hey guys, I just committed a fix for this. Can you test from DRUPAL-5 branch or when a new dev snapshot gets packaged up in a few hours and report back?
If it works for y'all, then I'll create a 1.0 release.
#5
Haven't actually sent the newsletter, but here's what I observed.
Before enabling the fixed module, 25 entries in the simplenews_tid_snid table, and 25 users are subscribed.
Enable your patched module as of 10-18 - and go to the page which subscribes by role. By default all boxes (I have four roles) are blank. Save that state (eg, press 'submit')
This erases the subscriptions. Behavior as expected (although it could be a problem if you are not expecting it to do that)
Go back to subscribe-by-role page and now check box for 'authenticated user' and submit.
All 25 users are subscribed.
Case closed on this bug, I think. One could make a case to save the original state as a reversion point )or perhaps export the list as a CSV file.) I can see innocent users collapsing in tears if they erase all of their predecessors work and the users who are nuked off the list are not in a single role...
Thanks !
/Hound
#6
Sorry, should have mentioned - I am using the 5.3 release version.
#7