This is part of the effort to break up core page handlers that no longer have to be in the main modules. So far I split out just comment_admin_settings(). I tried cutting out comment_admin() and related functions, but I keep getting a white screen and I don't know how to fix it. Maybe someone with more skills can step in.

For more info see the drupal groups page at http://groups.drupal.org/node/4179/

CommentFileSizeAuthor
#5 comment_49.patch31.43 KBCrell
#1 comment_48.patch37.93 KBCrell
comment_pages.patch9.41 KBbennybobw

Comments

Crell’s picture

Crell commented
Assigned: Unassigned » Crell
Status: Needs work » Needs review
StatusFileSize
new comment_48.patch37.93 KB

Here's a more complete version.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Comment module has been split already.

Crell’s picture

Crell commented
Status: Fixed » Needs work

No it has not. It had theme functions factored out, not page handlers. That still needs to be done, but of course the module has been updated since this patch was written so it no longer applies.

catch’s picture

catch
he/him
Primary language English
commented

Whoops, sorry!

Crell’s picture

Crell commented
Status: Needs work » Needs review
StatusFileSize
new comment_49.patch31.43 KB

Take 3...

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly.

I added, deleted, edited and previewed comments. Changed settings, enabled comment controls and played with those. No errors, notices, warnings or anything else unexpected.

RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Good job. I've committed this to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.