The enable/disable admin modules functionality is great but it's a shame that its hard-coded. A simple drupal_alter() would greatly enhance this and allow contribs to specify whether they or any of their submodules should be considered "admin modules".

CommentFileSizeAuthor
#3 1635228-3.patch612 bytesareke
#1 admin_menu-developer-modules-alter-1635228-1.patch593 bytesalexweber

Comments

alexweber’s picture

alexweber commented
Status: Active » Needs review
StatusFileSize
new admin_menu-developer-modules-alter-1635228-1.patch593 bytes

Attached is a patch that implements this.

The next step is probably getting contribs to implements this and gradually reduce the hard-coded list, but that's another issue... :)

areke’s picture

areke commented
Issue summary: View changes
Status: Needs review » Closed (fixed)

admin_menu.inc was removed from the module, and this code does not exist anywhere else. This is no longer an issue.

areke’s picture

areke commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 1635228-3.patch612 bytes

Oops, I made a mistake. The patch actually works fine; however, drupal_alter() is deprecated in 8.x. \Drupal::moduleHandler()->alter() should be used instead.
Here's an updated patch.

alexweber’s picture

alexweber commented

This would be really cool + a backport too...

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

I have created a fork of admin_menu 8.x-3.x on github. Please help me fix it for Drupal 8
PRs are welcome. https://github.com/jibran/admin_menu

alexweber’s picture

alexweber commented

@jibran, sounds like a better idea! Are the 8.x issues getting moved over by any chance?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

My plan is to first get it up and running again then we can talk about the issues.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Closed (won't fix)

The 'disable development modules' functionality has been removed as of #2392519: Remove 'Disable Development modules'.

alexweber’s picture

alexweber commented

That's too bad, although it's nice to have some closure for this issue... :)

edit: in hindsight, good call removing that functionality though