the help documentation and last confirmation prompt before install asks for a makefile. we should not be doing that if the platform already exists.

CommentFileSizeAuthor
#4 provision-no_makefile_for_existing_root-1635628-4.patch2.79 KBergonlogic

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

This is about hostmaster-install?

anarcat’s picture

anarcat commented

yes.

anarcat’s picture

anarcat commented

or maybe it's the debian package that prompts...

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
StatusFileSize
new provision-no_makefile_for_existing_root-1635628-4.patch2.79 KB 
 [...]
 Aegir DB password: <prompted>
 Aegir version: 6.x-2.0-rc2
 Aegir platform path: /var/aegir/hostmaster-6.x-2.x
 Aegir makefile: /var/aegir/.drush/provision/aegir.make
 Admin email: me@ergonlogic.com

Do you really want to proceed with the install (y/n):

Despite the fact that I had specified a platform, and not specified a makefile, I got this confirmation prompt. Is this what you're referring to? If so, the attached patch clears that up. Also, the possibly incorrect makefile doesn't get saved into the hostmaster platform alias.

anarcat’s picture

anarcat commented
Status: Active » Needs work

no no... it's an actual prompt i mean. i don't remember, but it's got to be in the debian package if it's not in hostmaster-install...

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs work » Postponed (maintainer needs more info)

It's still unclear what you mean then...

I still think the fix in #4 is worthwhile.

anarcat’s picture

anarcat commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

yeah, I guess I don't know anymore. go ahead with that patch, i'll reopen if i find this again.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Fixed in 4dabe5c.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 4dabe5c on 6.x-2.x, 7.x-3.x, 6.x-2.x-backports, dev-helmo-3.x by ergonlogic: 
    Issue #1635628: Do not talk about a makefile if installing over an...