We need to comply the PSR-0 standard that consist in moving all the tests to the directory views/lib/Drupal/views/Tests and declare it's namespace ensuring to do the fixing of global classes to load correctly and the test runs correctly.

#1637412: Convert Handler tests to PSR-0
#1637624: Convert comment tests to PSR-0
#1637552: Converted Style Plugin tests to PSR-0
#1637666: Convert user tests to PSR-0
#1637668: Convert plugin tests to PSR-0
#1637672: Convert field tests to PSR-0
#1637736: Convert user interface test to PSR-0

#1638866: Convert access tests to PSR-0
#1639168: Convert analyse tests to PSR-0
#1641654: Convert argument default tests to PSR-0
#1638946: Convert argument validator tests to PSR-0
#1638882: Convert basic tests to PSR-0
#1641656: Convert cache tests to PSR-0
#1639250: Convert Exposed form tests to PSR-0
#1639074: Convert glossary tests to PSR-0
#1641662: Convert groupby tests to PSR-0
#1641670: Convert module tests to PSR-0
#1641672: Convert pager tests to PSR-0
#1641694: Convert query test to PSR-0
#1641678: Convert translatable tests to PSR-0
#1641684: Convert upgrade tests to PSR-0
#1641688: Convert generic view test to PSR-0

CommentFileSizeAuthor
#20 1637532-root-tests-psr0.patch20.78 KBPedro Lozano
#17 1637532-Converted-ViewsAccessTest-to-comply-PSR-0-II.patch3.41 KBcitlacom
#15 1637532-Convert-BasicTest-to-PSR-0.patch10.69 KBPedro Lozano
#14 1637532-Convert-ArgumentValidator-test-to-PSR-.patch10.58 KBPedro Lozano
#13 1602372-Convert-views-Glossary-test-to-PSR-0.patch4.36 KBPedro Lozano
#12 1602372-Convert-analyze-test-to-PSR-0.patch9.45 KBPedro Lozano
#10 1637532-Convert-ExposedForm-test-to-PSR-0.patch8.94 KBPedro Lozano
#6 1602372-Convert-views-Glossary-test-to-PSR-0.patch4.36 KBPedro Lozano
#5 1602372-Convert-analyze-test-to-PSR-0.patch9.45 KBPedro Lozano
#2 1637532-Converted-ViewsAccessTest-to-comply-PSR-0.patch2.64 KBcitlacom
#1 1637532-Converted-ViewsAccessTest-to-comply-PSR-0.patch21.86 KBcitlacom

Comments

citlacom’s picture

citlacom commented
StatusFileSize
new 1637532-Converted-ViewsAccessTest-to-comply-PSR-0.patch21.86 KB

Here is my first patch that comply PSR-0 for ViewsAccessTest.

citlacom’s picture

citlacom commented
StatusFileSize
new 1637532-Converted-ViewsAccessTest-to-comply-PSR-0.patch2.64 KB

Same patch for ViewsAccessTest but with git option renames = copies. Much better, more simple.

Pedro Lozano’s picture

Pedro Lozano commented

I'll copy here the 2 patches that I sent on the 'config' issue.

Pedro Lozano’s picture

Pedro Lozano commented

The AnalyzeTest.

Pedro Lozano’s picture

Pedro Lozano commented
StatusFileSize
new 1602372-Convert-analyze-test-to-PSR-0.patch9.45 KB
Pedro Lozano’s picture

Pedro Lozano commented
StatusFileSize
new 1602372-Convert-views-Glossary-test-to-PSR-0.patch4.36 KB

The GlossaryTest.

dawehner’s picture

dawehner
Primary language German
commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
Status: Active » Needs review
Issue tags: +VDC

Now the testbot should come in

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: -VDC

Now the testbot should come in

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work
Issue tags: +VDC 
+++ b/lib/Drupal/views/Tests/GlossaryTest.phpundefined
@@ -0,0 +1,64 @@
+ * Definition of ViewsGlossaryTestCase.

Definition of Drupal\views\GlossaryTest

+++ b/lib/Drupal/views/Tests/GlossaryTest.phpundefined
@@ -0,0 +1,64 @@
+use \ViewsSqlTest;

use ViewsSqlTest (without the backslash)

Pedro Lozano’s picture

Pedro Lozano commented
Version: 8.x-3.x-dev » 7.x-3.x-dev
Status: Needs work » Active
Issue tags: -VDC
StatusFileSize
new 1637532-Convert-ExposedForm-test-to-PSR-0.patch8.94 KB

The ExposedForm test.

Pedro Lozano’s picture

Pedro Lozano commented
Issue tags: +VDC

Retagging but I cannot set the version back to 8.x

Pedro Lozano’s picture

Pedro Lozano commented
StatusFileSize
new 1602372-Convert-analyze-test-to-PSR-0.patch9.45 KB

Removing the backslash from the Analyze test.

Pedro Lozano’s picture

Pedro Lozano commented
StatusFileSize
new 1602372-Convert-views-Glossary-test-to-PSR-0.patch4.36 KB

Removing the backslash from the Glossary test.

Pedro Lozano’s picture

Pedro Lozano commented
StatusFileSize
new 1637532-Convert-ArgumentValidator-test-to-PSR-.patch10.58 KB

This is the ArgumentValidator test class.

Pedro Lozano’s picture

Pedro Lozano commented
StatusFileSize
new 1637532-Convert-BasicTest-to-PSR-0.patch10.69 KB

Converted the BasicTest.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 7.x-3.x-dev » 8.x-3.x-dev

Set to "needs review" when you're done uploading patches.

citlacom’s picture

citlacom commented
StatusFileSize
new 1637532-Converted-ViewsAccessTest-to-comply-PSR-0-II.patch3.41 KB

Removed backslash from use ViewsSqlTest and removed Views from class and file name.

Pedro Lozano’s picture

Pedro Lozano commented
Title: Convert existing tests to PSR-0 » [META] Convert existing tests to PSR-0
Pedro Lozano’s picture

Pedro Lozano commented
Issue summary: View changes

Updated issue summary.

Pedro Lozano’s picture

Pedro Lozano commented

From now on we will create individual issues for each test in the root test directory and a different issue for each subdirectory.

Pedro Lozano’s picture

Pedro Lozano commented
Issue summary: View changes

Updated issue summary.

Pedro Lozano’s picture

Pedro Lozano commented
Issue summary: View changes

Updated issue summary.

Pedro Lozano’s picture

Pedro Lozano commented
Issue summary: View changes

Updated issue summary.

Pedro Lozano’s picture

Pedro Lozano commented
Issue summary: View changes

Updated issue summary.

Pedro Lozano’s picture

Pedro Lozano commented
StatusFileSize
new 1637532-root-tests-psr0.patch20.78 KB

This patch moves to PSR-0 all tests in the root /tests directory except for UI and query.

Pedro Lozano’s picture

Pedro Lozano commented
Issue summary: View changes

Updated issue summary.

aspilicious’s picture

aspilicious commented
Status: Active » Fixed

done

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.