Convert comment tests to comply PSR-0

CommentFileSizeAuthor
#7 1637624-FilterCommentUserUidTest-ArgumentCommentUserUidTest-III.patch2.08 KBcitlacom
#5 1637624-FilterCommentUserUidTest-ArgumentCommentUserUidTest-II.patch3.09 KBcitlacom
#2 1637624-FilterCommentUserUidTest-ArgumentCommentUserUidTest.patch2.81 KBcitlacom

Comments

dawehner’s picture

dawehner
Primary language German
commented
Version: 7.x-3.x-dev » 8.x-3.x-dev

.

citlacom’s picture

citlacom commented
Status: Active » Needs review
StatusFileSize
new 1637624-FilterCommentUserUidTest-ArgumentCommentUserUidTest.patch2.81 KB

Here is the patch.

damiankloip’s picture

damiankloip commented

This looks ok to me, might be good for someone like aspilicious to check though.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Looks good, (if tests are green)

citlacom’s picture

citlacom commented
StatusFileSize
new 1637624-FilterCommentUserUidTest-ArgumentCommentUserUidTest-II.patch3.09 KB

Here new patch that change 'new view' lines to View camel case.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Needs work

This patch sadly doesn't apply at the moment

citlacom’s picture

citlacom commented
StatusFileSize
new 1637624-FilterCommentUserUidTest-ArgumentCommentUserUidTest-III.patch2.08 KB

Here new patch.

citlacom’s picture

citlacom commented
Status: Needs work » Needs review

needs review.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community 
+++ b/lib/Drupal/views/Tests/Comment/ArgumentCommentUserUidTest.phpundefined
@@ -2,15 +2,19 @@
+use Drupal\simpletest\WebTestBase;

This isn't needed I think

+++ b/lib/Drupal/views/Tests/Comment/FilterCommentUserUidTest.phpundefined
@@ -2,15 +2,20 @@
+use Drupal\simpletest\WebTestBase;

Same

Other than that this should be good :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +PSR-0

Corrected that and committed

Automatically closed -- issue fixed for 2 weeks with no activity.