Twitter Chat need review [#1638102]

Beautiful Client Experience

Itweetlive free live chat widget connects your visitors to twitter in seconds.Whenever your visitors type in the widget area, it's immediately convertrd into a tweet sent to your twitter account!
You can now easily continue the conversation from your current engagement platform or use itweetlive to engage in a whole new level, using advanced tweet grouping tools, measure your replies with our engagement analytics tools and much more!

Benefits
* Convert visitors to customers
* Increase customer satisfaction
* boost your twitter presence
* Completely free & dead simple integration
* Use your existing twitter platform
* no proprietary tools to learn!
* Extensive grouping and analytic tools
* Provide 24/7 Tech support

It is for Drupal 7.5

Comments

Comment #1

ordermind commented 18 June 2012 at 18:41

Manual Review of 7.x-1.x branch:
First of all, the downloaded folder contains an .info file and a zip file. The zip file needs to be extracted in order to access the project. From the looks of it, the archive contains the 7.x-1.0 branch of the project. This is wrong. Instead the 7.x-1.x project files should be located directly in the root folder of the branch.

Moving on, you haven't written any documentation at all for your functions. All functions should be documented, see http://drupal.org/node/1354 for current standards.

Also, your "twitterchat_help" function doesn't return anything. All projects should define a help text, see http://drupal.org/node/632280 for more info.

Finally, in twitterchat.module, there's a function called "_zopim_visibility_user_test". This function should have the prefix of "_twitterchat" instead to avoid compability issues with other modules, see http://drupal.org/coding-standards#naming for more information.