Typo in install file ! [#163908]

Hi,
found a typo in privatemsg.install delivered with the latest dev version that prevents the installation of the privatemsg_mails table:

      db_query("CREATE TABLE {privatemsg_mails} ) 
        description varchar(255) NOT NULL, ...

--> The bracket ")" after "{privatemsg_mails}" must be an opening bracket.

Comment	File	Size	Author
#3	privatemsg.tgz	1.98 KB	olio
#1	installer_fix.patch	1.41 KB	liam mcdermott

Comments

Comment #1

liam mcdermott commented 8 August 2007 at 14:10

Status:

Active

» Needs review

Status	File	Size
new	installer_fix.patch	1.41 KB

Drupal threw an error for me when installing this module too:

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') description varchar(255) NOT NULL, type varchar(255) NOT N' at line 1 query: CREATE TABLE privatemsg_mails ) description varchar(255) NOT NULL, type varchar(255) NOT NULL, subject varchar(255) NOT NULL, body varchar(255) NOT NULL, notification_subject varchar(255) NOT NULL, notification_text_body varchar(255) NOT NULL, notification_html_body varchar(255) NOT NULL, notification_group_text_body varchar(255) NOT NULL, notification_group_html_body varchar(255) NOT NULL, mailkey varchar(255) NOT NULL, PRIMARY KEY (mailkey) ) /*!40100 DEFAULT CHARACTER SET utf8 */; in /home/httpd/vhosts/apaddedcell.com/httpdocs/includes/database.mysql.inc on line 172.

There are a couple of closing brackets in the install file that should be opening ones. The attached patch fixes this. How many other bugs raised here are because MySQL does not create that table? :)

Comment #2

olio commented 9 August 2007 at 17:47

Oops, didn't realized that there were some more of these nasty brackets. Was already happy that I had found the first one - even a blind man may sometimes hit the mark.. ;o))

Meanwhile, I applied the patch, deleted the privatemsg tables and the privatemsg entry in the system table, then reinstalled the module : now everything seems to work fine again.

Thanks for the patch (and the nice module!) :o)

Comment #3

olio commented 20 August 2007 at 08:10

Title:	Typo in install file	» Typo in install file !
Priority:	Normal	» Critical
Status:	Needs review	» Active

Status	File	Size
new	privatemsg.tgz	1.98 KB

Hello?
In the update version this error in the install file persists (Line 113, closing bracket) ! Without this tiny correction of the install file the whole module won't work correctly for users doing a fresh install. (I attached a corrected version of the install file.)

Thanks again.