Make use of entity labels in templates

trying to improve the issue title.

More details using the node example:
When linking to a node the node->label() is used instead of the node title. But when something specifically refers to the node title, as $title in templates - we've been staying with the node title. Considering that the label property can be altered, it would be weird to don't get the title in $title. So, if we want to go with entity labels in the templates as well it should probably be $label or $entity_label, while $title could be available as well.

I spoke with some themers at the coding sprint drupalcon munich (mortendk and others).

they agreed that we should use the same terminology for the themers and the developers.
Because it makes no real sense to show the title (node.tpl.php and taxonomy_term.tpl.php are mostly used to show something to the user) we agreed to use the label instead. To not confuse themers we remove the $title completly.

attached patch does this.

I also wanted to first change the $title_prefix and $title_attributes variables. but I saw in block.tpl.php this:

  <?php print render($title_prefix); ?>
<?php if ($block->subject): ?>
  <h2<?php print $title_attributes; ?>><?php print $block->subject ?></h2>
<?php endif;?>
  <?php print render($title_suffix); ?>

so we are already mixing title and non title things, which I decided to not change $title_prefix to $label_prefix

Based on all the feedback you got and the cross-check with existing subsystems, I think this should be ready to go.

This change looks good to me, I agree with everything in #2.

+++ b/core/modules/taxonomy/taxonomy-term.tpl.phpundefined
@@ -12,7 +12,7 @@
  * - $term_url: Direct url of the current term.
- * - $term_name: Name of the current term.
+ * - $term_label: Name of the current term.
  * - $attributes: An instance of Attributes class that can be manipulated as an

Note that there's also $name a few lines above. I think we should actually just have $label and remove $name and $term_name.

Oh, cross-post. Re-adding tags. I do think the $name/$term_name thing should be fixed. Given that $term_name is used in the template, $name might not even exist and might just be a documentation bug.

@Berdir
yes, there is already a patch for this: #1751054: Taxonomy template variables are getting merged with the term itself (security aspects of $name variable were documented wrong)

Ah, yes, if there's already an issue then this is fine with me. Still not 100% about $term_label vs. $label.

discussed with Berdir in IRC, we agreed to unify the variables so that they are the same in node.tpl.php

Looks good. Will conflict with #1637342: Add entity_url() and entity_l() wrapper functions to simplify using EntityInterface::uri(), might make sense to get that one in first.

Hmm the other one is already CNW for a re-roll, so I'm going to go ahead and commit this so it's out of the way. This all seems reasonable to me. Committed/pushed to 8.x.

Change notice posted at http://drupal.org/node/1776718 (aimed at themers, although twig might change this altogether anyway :D) I don't think this deserves a CHANGELOG.txt entry, so off we go (off from the sprint that is). Thanks all!

Note that this caused XSS vulnerabilities in D7 templates that are ported to D8: #1811684: XSS: Bartik's node.tpl.php prone to XSS (prints $title)