I wanted to make a sub-theme to keep my customizations independent from this theme, but there are some parts of this theme that do not allow use with a sub-theme.

The attached patch resolves the problems that I found with using this theme as a parent theme.

CommentFileSizeAuthor
business_sub.patch7.58 KBkswan

Comments

devsaran’s picture

devsaran commented
Status: Active » Closed (works as designed)

I have used the theme variable name for most of my theme.. SO, If a user install many of my theme, There will be conflicts with the variable name..

kspal’s picture

kspal commented

I back kswan's suggestion: a theme without subtheming capability is considered as bad practice today.

But, Saran, do you really need to explicitly specify the theme name in these 2 files? I may be wrong, but I think the theme_get_setting method (and related) only apply to the current theme. So that wouldn't be an issue if a user install many of your themes.
=> Do you want to try on your own pc ?

[Edit]
Actually, you can replace your hard-coded theme name by the global variable $GLOBALS['theme'] , that works in most location I had a look at.

smptebars1’s picture

smptebars1 commented

I agree, we need to be able to create this as a sub-theme. I have a client that really likes the design you have Saran. What do I need to do to make this process possible. A small step by step would be great or is this fixed in 1.9 version? Thanks so much