Hello captcha maintainers, developers,

I'd like to contribute more efficiently to the captcha module. I think the captcha module still needs some more love before it get released as stable. I am more than willing to help with this (I hope my previous contributions made this clear).

I am therefore applying for a Drupal CVS account. In order to complete the application I need one of the captcha module maintainers agreeing to give me CVS access to the captcha module.

Thanks in advance,
Soxofaan

Comments

GoofyX’s picture

GoofyX commented

I suppose you don't have a CVS account at all. First, complete the form here. Your cvs account will not take more than a day or two to be created.

As for the captcha project, your patches have been valuable and the project has reached a usable 3.0-rc1 status, which is great, considering the project's importance in the war against spammers. I'm sure you'll get full access to the project.

Nice work soxofaan!

soxofaan’s picture

soxofaan commented

I suppose you don't have a CVS account at all. First, complete the form here. Your cvs account will not take more than a day or two to be created.

I already submitted that form and got an answer, in which the CVS administrator asked me to get an agreement of the current captcha module maintainer (which is wundo, I guess?).

GoofyX’s picture

GoofyX commented

I guess my assumption was wrong (I went through your account tracker and did not see any code commits...).

Yes, the project maintainer must grant you full access to the project.

wundo’s picture

wundo commented

Hi Soxofaan,
Thank for all the work you have been done to Captcha, but right now I guess we do not need more committers, RobLoach joined the team one month ago and know we do not have enough patches ready for commits.
Adding a new man would just add more Grey Areas.

heine’s picture

heine commented

:(

I do feel somewhat disappointed. Without Stefaan, there would not have been a 'nearly' functional Captcha branch.

soxofaan’s picture

soxofaan commented

I also feel disappointed.

we do not have enough patches ready for commits.

I understand you don't need more patch commiters, but at this point in time I'm mainly a patch generator. I still have patches in queue from my personal branch and still have some ideas for additional features. Right now, submitting a patch and waiting before it gets committed means a lot of friction for my work cycle and gets sometimes a bit frustrating. I'd just like to contribute more efficiently.

soxofaan’s picture

soxofaan commented

we do not need more committers

According to http://drupal.org/project/developers/8404?sort=asc&order=Last+commit, there are indeed around 19 commiters for captcha. But if you look at their last commit, there are only four of them which could be called 'active' since I started with my rewrite in June this year.

we do not have enough patches ready for commits.

At the moment I count nine patches of me that are waiting for review/commit in the tracker. Sometimes patches overlap (e.g. the changes from http://drupal.org/node/158613 are scattered in many files/functions) which means that I have to rework a patch if one of them is commited. At the moment I have to maintain around seven different branches of the captcha module on my setup to be able to generate patches against the CVS head, which is frustrating.

I just want to make the captcha module better/stable/usable. Right now I feel like I lose to much time with waiting.

So please reconsider my request.

wundo’s picture

wundo commented

According to http://drupal.org/project/developers/8404?sort=asc&order=Last+commit, there are indeed around 19 commiters for captcha. But if you look at their last commit, there are only four of them which could be called 'active' since I started with my rewrite in June this year.

Sorry, but right now, just two people have CVS perms to Captcha, myself and Rob Loach.
Dries, Heine and the other CVS admin often do commits, but they are not really committers.
And for me all that page looks wrong, as, for example, I could not found any commit from Claudiu Cristea in the last 4 weeks, maybe the code to define who are the devellopers from captcha is buggy.

At the moment I count nine patches of me that are waiting for review/commit in the tracker. Sometimes patches overlap (e.g. the changes from http://drupal.org/node/158613 are scattered in many files/functions) which means that I have to rework a patch if one of them is commited. At the moment I have to maintain around seven different branches of the captcha module on my setup to be able to generate patches against the CVS head, which is frustrating.

One thing we need to keep in mind is that sometimes not all our patches gonna be commited. I gonna do an effort this week, an review all your patches.

wundo’s picture

wundo commented
Status: Active » Closed (fixed)
robloach’s picture

robloach
he/him
commented
Status: Closed (fixed) » Active

Do it... I believe that if we keep reviewing each other's patches, we won't run into any problems.

soxofaan’s picture

soxofaan commented

Thanks!

I already have a CVS account (for CAPTCHA Pack and GeSHi filter), so I only need CVS write permission for the CAPTCHA project.
Can you grant these?

I'll start with commiting a harmless subset of the patch at http://drupal.org/node/168853

robloach’s picture

robloach
he/him
commented

No, I can't grant it. Only wundo can, I believe. Remember the undocumented rule that when you commit something, it has to be reviewed by at least one other developer and approved by all the others.

soxofaan’s picture

soxofaan commented

Ok.
I guess this practically means you'll have to do all the commit work (haven't heard wundo in a while).

PS: the patch I was referring to is now at http://drupal.org/node/168853#comment-307075

wundo’s picture

wundo commented
Status: Active » Fixed

Hi folks,
I`m in Barcelona for DrupalCon, this is why I had been inactive for a while... :)

I do believe that with we follow this simple rule: "when you commit something, it has to be reviewed by at least one other developer and approved by all the others."
we will not have any problem..

Would be great with we keep posting infos in Captcha`s user group. And would be great if we could meet in some IM.
Do you use IRC soxofaan?

Congratulations for your great work, and welcome to the team! :))

soxofaan’s picture

soxofaan commented

Thanks guys

DrupalCon/Barcelona ... lucky you
(if I wouldn't have too much work in my day job, I would have considered also going there)

I'm not an experienced IRC user, I have gmail talk and msn accounts though (but I won't post it here in public) for some occasional chatting.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)