Summary

In the context of #1635084: Track import status of files in the locale .po file directory, a patch reached core with a typo. It calls coddition instead of condition.
Tests didn't catched this issue, but tests being developed on #1189184: OOP & PSR-0-ify gettext .po file parsing and generation catched it.

Original report

We made a typo in a patch and it finished in core.

CommentFileSizeAuthor
#1 1642966.patch532 bytespenyaskito

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 1642966.patch532 bytes

Patch attached.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Good catch! However, this means we lack automated test coverage for this part of the code. :( Marking "Needs tests."

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue tags: +D8MI, +sprint, +language-ui
jcisio’s picture

jcisio commented
Status: Needs work » Closed (duplicate)

There is also a waiting patch at #1635084: Track import status of files in the locale .po file directory for a few more changes. Marking this as duplicate?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -Needs tests, -sprint

Thanks, removing off sprint, keeping an eye on #1635084: Track import status of files in the locale .po file directory.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

Explaining how it was catched