Posted by Dries on May 4, 2003 at 6:00am
5 followers
Jump to:
| Project: | Drupal core |
| Version: | x.y.z |
| Component: | Node system |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Something is wrong with the teaser break; it is being filtered out after preview because of the < and > characters, I think. The exact problem is to be investigated.
Comments
#1
I can't replicate: both in stories and static pages <!--break--> seems to work.
Could you provide some steps to replicate?
#2
I think that the break-tag (<!--break-->) gets stripped out upon preview when you enable the HTML filter. Try this: enable the HTML filter, go to the forum topic submission page, enter some text with a break-tag in it and click "Preview". Is the preview correct and is the break-tag still there (so that it continues to work when you click preview again)?
#3
ok, now I can replicate.
this needs some thought: you need to filter html comments out, or pages get mangled if you open a comment without closing it (try, it's funny!)
so perhaps we should use another break tag, something like "<teaser />"?
#4
+1 for <teaser />
#5
-1 for
If we fix the filter system to filter only on output, this bug will surely go away?
If you want to have an HTML teaser break, surely we should make sure we only use standard HTML? Anything else will break validation.
#6
Al Maw wrote:
> 20/05/2003 - 04:15 : Al Maw
> -1 for
>
> If we fix the filter system to filter only on output, this bug will
> surely go away?
>
> If you want to have an HTML teaser break, surely we should make sure we
> only use standard HTML? Anything else will break validation.
>
Remember, though, the teaser is part of what gets filtered on output.
It won't break validation cause it never (shouldn't ever) shows up. I
don't see anything wrong with using a custom tag to indicate to drupal
to mark for breaking the teaser.
#7
As of a few minutes ago, Drupal uses "on output" filters. This bug is now fixed and I'm marking it accordingly.
#8
Verified. CLOSING.