| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | Seven theme |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | a11ySprint, accessibility, aria |
Issue Summary
Problem/Motivation
As a screenreader user, I need helpful ARIA landmarks so I can efficiently use the Drupal administration screens and jump to the correct parts of each page. The Seven theme for administration tasks needs ARIA landmarks to improve its accessibility.
Proposed resolution
Screenshots are attached showing the proposed ARIA landmarks to apply to different sections of the page on Drupal administration screens in the Seven theme.
The first screenshot shows the basic landmarks that should appear on every page. The second one shows internal landmarks on some pages that have multiple areas of tools. The third screenshot shows that the tabs (primary tabs and secondary tabs) should get a navigation landmark.
Remaining tasks
Based on the screenshots attached, the appropriate ARIA attributes should be added to the specified elements of the admin pages. This should be a simple job of adding appropriate markup into Seven theme template files.
User interface changes
None, except for screenreader users who will be able to navigate within a page using landmarks.
API changes
None.
(Thanks to David MacDonald who works with the W3C and attended the Montreal Drupal Accessibility Sprint for recommendations on these landmarks.)
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| aria-landmarks-seven-admin.png | 70.93 KB | Ignored: Check issue status. | None | None |
| aria-landmarks-seven-admin-internal.png | 180.36 KB | Ignored: Check issue status. | None | None |
Comments
#1
#2
Shouldn't these ARIA landmarks be in the default templates too?
#3
@JohnAlbin, I suggest we handle the other themes and the default templates as a separate issue (one has not been opened yet, AFAIK). The reason is that they are actually more complex with many more regions that need landmarks (like sidebars, footer, and such). The Seven theme and administration screens are comparatively simple.
But if you feel otherwise, we could add specs here for all core themes and make this one mega-issue to add ARIA landmarks.
#4
Let's see if this gets things moving.
#5
forgot to tag.
#6
+1
#7
#4: seven-aria-landmark-roles-1643410-4.patch queued for re-testing.
#8
tagging.
#9
The last submitted patch, seven-aria-landmark-roles-1643410-4.patch, failed testing.
#10
The file the patch was affecting has moved to
core/themes/seven/templates/page.tpl.php. Re-rolling.#11
#10: seven-aria-landmark-roles-1643410-10.patch queued for re-testing.
#12
This looks great. I just added a visual using https://addons.mozilla.org/en-us/firefox/addon/juicy-studio-accessibilit... and it's going to be a great addition!
#13
Drat, remembered when reviewing Bartik that we'd agreed to use
role="contentinfo". Adding that now. Back to review.#14
Cool, thanks Mike! :)
I'll definitely have to use that extension in the future!
#15
Assigning to me to review.
#16
Sorry about the delay in getting this RTBC'd.
Everything's looking good!
#17
Looks sensible to me. Committed/pushed to 8.x.
#18
Great!
#19
Thanks!
#20
Adding link to #1913692: Convert Seven to HTML5 - not really a child issue, but related. Not sure why it wasn't done before.
#21
Automatically closed -- issue fixed for 2 weeks with no activity.