Hi again Berdir, here the patch and the new issue you asked :)
The patch is 7.x-2.x-dev and sandbox module from michaek.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | masterchiefv3.patch | 11.95 KB | MasterChief |
| #4 | masterchiefv2.patch | 13.38 KB | MasterChief |
| masterchief.patch | 31.5 KB | MasterChief |
Comments
Comment #1
berdirComment #3
berdirIt looks like you made your patch against a dev snapshot release of Userpoints. You need to use a git checkout or you will see stuff like this.
Same here. The patch won't apply because these lines don't exist in a git checkout.
Should have a space before and after =>, some for all instances below.
Comment #4
MasterChief commentedOk new patch :)
Comment #6
berdirThis part is still here, you need to remove the changes in the .info files or it won't apply.
I can commit this change once you fixed this and then you can continue with your patch on top of this one.
Comment #7
MasterChief commentedI think it will be good now :)
Comment #8
berdirYes, looks good.
I think we're missing a few places where the function isn't yet used, liked services and views integration. However, we fix these as we find them and views integration is going to be overhauled completely based on entity API anyway.
Thanks, commited.
Comment #9
IWasBornToWin commentedMasterchief,
Does this have anything to do with the new patch I just paid you to do? Is that patch committed to the latest user points dev yet?
Thanks
Comment #10
IWasBornToWin commentedBerdir/Materchief? Is new userpoints with decimals patch committed to dev version yet? Thanks
Comment #11
MasterChief commentedNot yet, i am waiting an answer from Berdir on the other issue, but you can use the version i sent you, you have all the new features minus the patch on this issue queue but it doesn't change anything for you as an user :)