"This advertisement is waiting approval" and always "pending" status (4.5)

Does anyone else notice this in the Banner module under their users/administrators under your website/banners?

Hey Jeremy!

I'm using Banner 4.5 along with Drupal 4.5.2 (has been showing as it does since upgrading both to 4.5 right from the get-go),
my server OS is unix - shared hosting, my server http://www.challengehost.com/website/web-site-hosting.html - php 4.3.2 so definitely not an issue with php 5
viewing this on Windows xp - mozilla and IE thus far

I'll attach what it looks like under:
mywebsite/banners
AND
mywebsite/admin/banner/view or edit (always defaults back to pending instead of enabled on specific banner views) BUT under admin/banner/list, shows status as enabled

I can handled the admin portion defaulting back to "pending" in the admin specific views under each banner, however, when it consistently is showing to specific users that their banner is still waiting for approval and pending YET enabled and working... well, you know :)

Lisa

Any new break throughs? Shall I perhaps grab newest banner.module version and go from there?

Lisa

I've upgraded, started anew scrapping my database content and testing with the latest and greatest... no change - still experiencing the above. Is there some trigger in the settings that will ensure a change in the message?

I've called up the code hoping to see SOMETHING within it that will offer a successful message to users under the mybanners section.

$output .= theme('table', $headers, $rows);
if ($banner->status == 0) {
// new banner, awaiting administrative approval
$output .= t('This advertisement is waiting approval.');
}
else if ($banner->unpublish_date) {
// if this banner expires, provide more information
if (($banner->status == 1) || ($banner->status == 2) ||
($banner->status == 3) || ($banner->status == 4)) {
$output .= t('This advertisement will be displayed until %date.', array('%date' => format_date($banner->unpublish_date, 'custom', 'M d, Y
')));
}
// status(5) == "blocked"
else if ($banner->status == 5) {
if (date > $banner->unpublish_date) {
$output .= t('This advertisement is expired.');
}
}
}

Because I'm allowing unlimited settings in that I have not set an unpublished date, is that perhaps why the message will not forcefully change? Now, I just tested to add an unpublish date to my test banner and there still is no change.

One thing I consistently notice is that when I go into mywebsite/admin/banner/"#"/edit, though active and enabled, the current view of the "status" of the banner defaults always to pending in the view.

Now with the CLEAN install, I'm at a loss... ????

Lisa

Hi Jeremy!

Followed all you said, thing is, by everyone, the banners ARE viewable. No Issues with that, the "My banners" or "Admin/banners" sections are continually telling the user the MESSAGE that "This advertisement is waiting approval" and "pending" is the status though they and all can see that the banner IS working.

- I dumped all banners in mysql,
- dropped my banner table,
- re-created my banner table with banner.mysql from cvs
- only am using CVS version banner.module,
- updated both Banner_file.php and Banner_db.php within drupal directory
- only have ONE banner currently going so nothing is mistaken and it is visible to all
- nothing to report from adding print_r($banner)" as banner is showing on page placement on right side column

Basically, the management system MESSAGE for "my banners" for the user is still showing prominently after they can know that their banner is "enabled" and "approved" that it's awaiting approval and still pending.

Guess I'm hoping for SOMETHING to change for their banner statistics so that message line of "This advertisement is waiting approval." will update to "'This advertisement will be displayed until %date.', array('%date' => format_date($banner->unpublish_date, 'custom', 'M d, Y '" or "This advertisement is expired." (However, I don't think it will update or change to anything else because I'm not inputting any start or end publish dates NOR have I slotted that the existing banner is expired yet. Is it possible for a code to state "Your advertisement is approved!"?)

Lisa

Yes, this does also affect user 1 or myself.

No, no dump of any variables occurred - What I did get was:

Parse error: parse error in /usr/local/share/doc/vhost/.../httpdocs/modules/banner.module on line 321

warning: call_user_func_array(): First argumented is expected to be a valid callback, 'banner_admin' was given in /usr/local/share/doc/vhost/.../httpdocs/includes/menu.inc on line 351.

THIS is where I put the code:

function banner_user_edit($banner) {
print_r($banner)"
$output = theme('banner_show', array2object($banner));

When I had upgraded to 4.5 from 4.4, I had a terrible time with getting the menu module to work and I had to reinstall the core from scratch and then add in table content and modules at leisure piece by piece to rebuild. I didn't have the banner module working in 4.4 so I know that wasn't part of the upgrade issue.

Interesting when you say: "The bottom right corner should have a drop down menu offering the choices "enabled" and "disabled", allowing the user to temporarily disable their own banner." I don't see this at all, sounds like a great functionality though. SEE ATTACHED :)

I'm feeling more and more "dumb" with trying to get this working. Haven't had this much difficulty since Mass mailer (though i still can't get that one working at all) AND I'm an habitual module tester!

Lisa

I guess if I'm having odd issues here that aren't working as most current CVS downloads of the banner module. IE, that pulldown for enable/disable, have never seen that before. Is there something else going on in my tables? Cache? Variables? that need to get thrown out SOME how SOME way?

Lisa

Just wanted to add that I tried to add this module and drupal - brand new - on another domain for testing and I'm still having same trouble.
It's so ODD cause I can see that all is working perfectly except the above messages are STILL the same. AND like I stated in the above reply, there are no pulldowns for user to "enable" or "disable" on their own in the status column.

WHY ME?!

Lisa

I can't thank you enough, Jeremy!

You went above and beyond with helping me out with this issue and then some!
If Drupal had a way to send kudos or be able to thank individuals who manage different projects/modules.

SUCH a small flaw causing a big difference! I myself use DBA on my main site for viewing, emptying, dropping... guess should utilize it for scripts from hereon in as well!

Lisa