This patch addresses the issue / feature that taxonomy_image.module requires to be useful to other modules to use in contexts other than inline images in an Only local images are allowed. tag, such as theming, CSS, image manipulation, multiple image handling/mixing, others...?

I moved a large chunk taxonomy_image_display() into taxonomy_image_get_object() which returns an object with several useful parameters about the image. I added taxonomy_image_get_url() which is required for theming and CSS where Only local images are allowed. tags usually aren't useful.

This patch includes the patch at http://drupal.org/node/164447 and was also rolled against the 5.x-1.0-beta1 release of taxonomy_image module. And therefore the issues described there also apply here.

Further, the image resizing chunk of code in taxonomy_image_display() has been edited in this patch but not yet tested at all.

CommentFileSizeAuthor
#6 taxonomy_image.module.patch14.84 KBnancydru
#2 164448.patch11.15 KBBevan
#2 164448-head.patch7.51 KBBevan
taxonomy_image enhancements.patch9.39 KBBevan

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Has anyone else checked this one?

I will review it. Is there any chance you could re-roll it with diff -u -p, please?

Bevan’s picture

Bevan commented
StatusFileSize
new 164448-head.patch7.51 KB
new 164448.patch11.15 KB

164448.patch is rerolled in the correct format. Remember that it includes http://drupal.org/node/164447

I updated the module (with CVS) and got several conflicts. I can't remember why I made many of the changes because it was so long ago and don't have time to work it out. So 164448-head.patch probably doesn't work. I'll try to find client-billable time to merge changes into head and reroll.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Thanks. Well, the file directory problem is already fixed in 5.x-1.x-dev. If you can't get a client to pay for it, you may have to do it for "love" like the rest of us. ;)

Bevan’s picture

Bevan commented

The issue isn't lack of passion. I'd love to be able to do stuff like this just for fun, and still be able to pay the bills, but I can't at the moment. :)

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

@Bevan, I was looking through this patch. You have added a "@todo" about clearing the cache. Taxonomy uses "static" to cache terms and vocabularies, not the 'cache' table. I don't think there's any point in clearing the cache; I'm commenting it out to avoid other problems, like killing Update Status. I might look at how to clear a "static" variable (I know 'unset' - but this would be cross-module).

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
StatusFileSize
new taxonomy_image.module.patch14.84 KB

This should be a complete patch against 5.x-1.x-dev. I think I got all your changes, plus I found some problems with taxonomy_image_save and taxonomy_image_delete, which are also fixed. Also, I moved "getimagesize" to taxonomy_image_get_object.

Please test this if you can. And anyone else, please feel free.

Bevan’s picture

Bevan commented

I reverted my modifications on the client site that uses this patch, updated on CVS and applied this patch. I did a quick test and everything looks great. More extensive testing would be great before committing. This will happen in the QA process of the client site and I'll report back on any issues.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Thanks.

Actually, since I have created 5.x-1.0, I think I will go ahead and commit this to 5.x-1.x-dev.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs review » Fixed
Bevan’s picture

Bevan commented

woot! Thanks! :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.