Expose settings to cTools export

Yes, but for drupal 7 first me thinks.

Attached patch fixes the machine_name unique key.

It's working like a charm!

Tks @q0rban!

I had a look at the patch and thank you for posting it. However the development of this module is long over (and this is a feature request), so let us just leave it as a patch for user that need it.

Mithy, do you mean that there won't be another stable release of this module that includes this functionality? (I might be confused, but wouldn't that be a wontfix?)

Does anyone know of any other modules that could do something similar that can be deployed easily using Features?

I tested the patch and it almost applied cleanly (rejected the .info file part) and it added a Login Destination setting in the features UI, but it didn't seem to actually export the data. The UI was also a little odd:

FYI: Jelle_S has created a patch that pretty much overhauled this module to bring it CTools power on another issue as well #1789652: make configuration of this module exportable as a feature.... probably these efforts should be combined.

Marking as a duplicate of #1789652: make configuration of this module exportable as a feature.

This was the earlier issue, so setting back to RTBC, as mithy says, it won't post, but at least people will see that there is a reviewed patch here.

That patch has end-of-line and spacing problems, rerolled.

patch didn't apply for me. Rerolled + tested.

Fixed one missing bit for saving rules. Rerolled again..

as infrequently as this patch is updated an interdiff would be really helpful. jus' sayin'

I have just tested #13 and it applies cleanly and creates nice features exportables. Thanks for this.

This doesn't apply cleanly to -dev.

Rerolled patch against 7.x-1.x -dev branch

Hi,

I had to fixup paths for making drush patching work. BTW, is there some way to avoid this? I happen to find a lot of patches that all need the -p1 option for patching. Drush however does by default use -p0 and fails on applying these patches.

Best regards,

Lennart

Reroll.

#20 didn't apply cleanly against the 7.x.1.x git version as it had packaging information in the .info diff

-files[] = login_destination.module
-files[] = login_destination.admin.inc
 configure = admin/config/people/login-destination
+dependencies[] = ctools
 ; Information added by drupal.org packaging script on 2013-09-30
 version = "7.x-1.1+0-dev"
 core = "7.x"

This patch fixes that.

Also added an isset to check to mitigate an error

  if (isset($rule->id)) {
    $form['id'] = array(
      '#type' => 'hidden',
      '#value' => $rule->id,
    );
  }

Changed the issue number in the patch filename.

#22 applied against the git version, but not against the packaged dev version.
I keep getting rejects on the removing of files in the .info
This patch applies against both git and packaged dev, but keeps the files in the info file.
I'll stop spamming this thread now, please review or fix the info!

We're using the patch in #23 successfully.

This patch doesn't apply cleanly to latest dev version.

Here is a reroll from the patch in #22. Since a lot of code in login destination changed since the last patch it was a lot of work to do the reroll. I also had to make some changes in the implementation:

• Since a login destination now has a 'enabled' property, menu items for enabling/disabling a rule are removed.
• All code previously added to login_destination.crud.inc, is now directly added to login_destination.module. This is because in the patch from #22 login_destination.module required 'login_destination.crud.inc' (so the code from 'login_destination.crud.inc' got always loaded) and as such I did not saw a reason why not to add the code directly to login_destination.module.
• Improved messages for translation on delete/revert form.

I've only shortly tested the changes myself, so it probably still needs some work. One thing that requires work is that all login destination rules will be marked as overidden when hitting the "Save configuration" button on the login destination overview page without changing anything. I also didn't test if the database update (login_destination_update_7002()) still works.

Thanks megachriz, Patch is clearly apply to latest dev branch and working perfectly, can anyone add overridden link on login destination overview page as mention in #26.

Hello - this thread has been open for 4 years. Is anyone able to push this through to completion?

This issue should be superseded by 2414169 - Expose settings to features

In any case the patch on this thread is 2 years old and doesn't even apply.