Closed (fixed)
Project:
Cookie Control
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
18 Jun 2012 at 18:47 UTC
Updated:
11 Jan 2013 at 16:59 UTC
Jump to comment: Most recent file
Comments
Comment #1
nickbits commentedI have attached a patch to upgrade the module to use Cookie Control JS Version 5. This brings in additional control, you can now select information, implicit or explicit consent methods. See http://www.civicuk.com/cookie-law/cookie_configuration_v5 for information on the different methods in full.
Essentially there are the following modes:
I have also corrected a few other bugs such as the double paragraph tags that were showing in some parts of the rendered code.
NOTE: I have not fully tested the patch with all settings in different browsers, so please do not use on production sites, use only on a test site. If you find any issues, please submit a patch to correct.
Thanks,
Nick
Comment #2
cshedden commentedHi nickbits,
Good job on this.
Any idea when this is going to be rolled into a beta version?
I'm running Drupal on windows and don't have development setup to roll that patch into the code - unless someone can point me in the right direction - I'm not a git user.
Cheers
Colin
Comment #3
nickbits commentedHi cshedden,
Good question. I don't know when it will be added into the development/beta snapshot, I don't have any privileges for this project, it is up to the maintainer to commit it.
You can get Git for windows ( http://msysgit.github.com/ ) and to apply a patch see the Drupal Docs ( http://drupal.org/patch/apply ).
Good luck,
Nick
Comment #4
buddare: GPL / distribution
I've obtained permission to include the Cookie Control script as part of the Drupal module.
I never got any notification from CivicUK about the new version of the JS library so overlooked this, sorry!
Comment #5
nickbits commentedExcellent, and no problem. I only found out by accident. Hope the patch works!
Comment #6
zanonmark commented+1 for me too to upgrade the library to get "explicit consent",
thanks for this good module,
Marco
Comment #7
tessa bakkerHi nickbits,
Against which version do I have to patch?
http://drupalcode.org/project/cookiecontrol.git
Patching against 1.x-dev (31 may) and version 1.5/1.4 fails.
Thanks,
Tessa
Comment #8
Homotechsual commentedHas this been actioned yet?
Comment #9
nickbits commentedHi Tssa,
I would have used the dev release closest to June 18th. It still works for me. Can you post the exact steps you took to try and patch it.
Nick
Comment #10
nickbits commentedHi MJCO,
I have asked for it to be committed, I am not a maintainer, nor do I wish to be, hence I do not have the privileges to commit. Perhaps if you request to the module maintainer he will commit it.
Regards,
Nick
Comment #11
reinier_post commentedYour patch is quite essential to our ability to use this module (as I understand it, opt-out is not good enough for Dutch law, so I need opt-in, your new 'explicit' mode).
It no longer applies 100% cleanly; while fixing it I thought I'd try 5.1 instead of 5.0.
The result is attached.
I have twiddled with the configuration options and they all appear to work; more thorough testing would be welcome.
Comment #12
buddadev branch now contains suport for cookie Control 5.1
Comment #14
BarisW commented@Reinier: you might want to check out http://drupal.org/project/ro_cookie_opt_in, which is opt-in based and offers logging as well.