Classes added to the primary/secondary links. Previous version had very odd menu classes. This patch isn't a big improvement since these arcane menu id's (mlid?) are the only way to reliably stick in classes. Would be better off if they are ID's but theme_links doesn't allow that on list items. Would be nice if we could modify it so it accepts ID's as an option and removes the redundant classes.

As it stands now, the primary links produce classes from "0" to X number of links. This is definitely a bug.

Primary/secondary local tasks, or "tabs" have classes to them. In Drupal 5 it was possible to override and get these classes in there but in Drupal 6, there's no information passed to the theme function to do anything short of brute force regex which is understood by few. --me included

Menu tree now has a depth class. This is difficult to select with css alone thanks to IE so these classes will make it a lot easier.

This may not be the best approach. Hopefully it'll get in with a few tweaks.

CommentFileSizeAuthor
menu_classes.patch5.32 KBdvessel

Comments

catch’s picture

Status: Needs review » Needs work

Needs a re-rolll.

dvessel’s picture

Title: Supply classes to menu system. » Supply classes to local tasks (tabs).
Version: 6.x-dev » 7.x-dev
Status: Needs work » Active

The primary/secondary links were fixed but classes for tabs are still not possible. -not cleanly anyway

effulgentsia’s picture

Version: 7.x-dev » 8.x-dev

What's still relevant here? If nothing, please close. If something that can make it into D7, please roll a patch and set version back to D7.

sun’s picture

Version: 8.x-dev » 7.x-dev
Component: theme system » markup

Yes, please. This does not break anything.

Marked #157876: Lack of CSS hooks on View / Edit tabs as duplicate.

jacine’s picture

Version: 7.x-dev » 8.x-dev
Status: Active » Needs work

We definitely need this, but it's way too late.

rv0’s picture

This feature would still be awesome in D8.

idebr’s picture

Issue summary: View changes
Status: Needs work » Closed (duplicate)

The markup for tabs has been fixed in #1999182: Dream mark up for tabs