Classes added to the primary/secondary links. Previous version had very odd menu classes. This patch isn't a big improvement since these arcane menu id's (mlid?) are the only way to reliably stick in classes. Would be better off if they are ID's but theme_links doesn't allow that on list items. Would be nice if we could modify it so it accepts ID's as an option and removes the redundant classes.
As it stands now, the primary links produce classes from "0" to X number of links. This is definitely a bug.
Primary/secondary local tasks, or "tabs" have classes to them. In Drupal 5 it was possible to override and get these classes in there but in Drupal 6, there's no information passed to the theme function to do anything short of brute force regex which is understood by few. --me included
Menu tree now has a depth class. This is difficult to select with css alone thanks to IE so these classes will make it a lot easier.
This may not be the best approach. Hopefully it'll get in with a few tweaks.
| Comment | File | Size | Author |
|---|---|---|---|
| menu_classes.patch | 5.32 KB | dvessel |
Comments
Comment #1
catchNeeds a re-rolll.
Comment #2
dvessel commentedThe primary/secondary links were fixed but classes for tabs are still not possible. -not cleanly anyway
Comment #3
effulgentsia commentedWhat's still relevant here? If nothing, please close. If something that can make it into D7, please roll a patch and set version back to D7.
Comment #4
sunYes, please. This does not break anything.
Marked #157876: Lack of CSS hooks on View / Edit tabs as duplicate.
Comment #5
jacineWe definitely need this, but it's way too late.
Comment #6
rv0 commentedThis feature would still be awesome in D8.
Comment #7
idebr commentedThe markup for tabs has been fixed in #1999182: Dream mark up for tabs