Book pages slighty disobey the node_access system because they always return a value for book_access('update'). This simple patch causes us to use node_access when the user has a chance of being able to update the current page.

CommentFileSizeAuthor
#3 book_26.patch1.37 KBmoshe weitzman
#1 book_25.patch882 bytesmoshe weitzman
tree.diff921 bytesmoshe weitzman

Comments

moshe weitzman’s picture

moshe weitzman commented
StatusFileSize
new book_25.patch882 bytes

i had the conditions reversed. thanks jonbob.

sulleleven’s picture

sulleleven commented

i noticed this a while back... thnx for the patch.
would a similar reason apply to the project modules issue nodes?

moshe weitzman’s picture

moshe weitzman commented
StatusFileSize
new book_26.patch1.37 KB

this version adds a 'revision pending' message as needed at bottom of the node view. the lack of this indicator confuses authors on drupal.org why they have no edit tab, and may remind recent editors why their edits are not showing up yet.

sorry for mixing two unrelated ideas in one patch. at least they affect the same single file

Anonymous’s picture

(not verified) commented

+1... the node_access fix is much-needed and the revision pending indicator would certainly be helpful on drupal.org and other sites using the moderation system.

dries’s picture

dries commented

Committed to HEAD.

Anonymous’s picture

(not verified) commented