"Hide if empty" option is not applicable to all styles, but it should be used with XML and now it's completely ignored.

CommentFileSizeAuthor
#8 views_data_export-1646596-empty-support.patch12.16 KBsteven jones
#3 views_data_export-1646596-3.patch2.06 KBdmitriy.trt
#1 views_data_export-1646596-1.patch1.56 KBdmitriy.trt

Comments

dmitriy.trt’s picture

dmitriy.trt commented
Status: Active » Needs review
StatusFileSize
new views_data_export-1646596-1.patch1.56 KB

Patch with the fix. Not sure about other styles, patch enables support for XML style only. But we can enable it for other styles with one line of code.

steven jones’s picture

steven jones commented
Status: Needs review » Needs work

This doesn't actually allow the XML style to use this though, still needs a little bit more work I think,.

dmitriy.trt’s picture

dmitriy.trt commented
Status: Needs work » Needs review
StatusFileSize
new views_data_export-1646596-3.patch2.06 KB

Yes, you're right. One more change has been lost at some point. Updated patch attached.

apmsooner’s picture

apmsooner commented

I applied this patch and seems to work just fine. Thanks!

steven jones’s picture

steven jones commented
Status: Needs review » Needs work
Issue tags: +Needs work

We should add some tests for this for sure, but indeed we should respect the hide if empty option.

apmsooner’s picture

apmsooner commented

Have been running on my site for a few weeks now with no problems at all.... the hide if empty patch worked quite well for me. Just FYI...

steven jones’s picture

steven jones commented
Assigned: Unassigned » steven jones

Let's add some tests!

steven jones’s picture

steven jones commented
Assigned: steven jones » Unassigned
Status: Needs work » Needs review
StatusFileSize
new views_data_export-1646596-empty-support.patch12.16 KB

Here's a patch for the testbot, that's the above patch, slightly re-factored and then some lovely tests.

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

Thanks everyone for the work, I've committed this to 7.x-3.x.

dmitriy.trt’s picture

dmitriy.trt commented

Great news! Thanks for your work on this module!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dromansab’s picture

dromansab commented

Hi,

is it possible to apply this solution to xls (Excel) files?

Thanks!

rgnyldz’s picture

rgnyldz commented
Issue summary: View changes
Issue tags: -

+1 for xls file support

g1r1p1’s picture

g1r1p1 commented

Any development on this. +1 for XLS support