This is what was breaking my debug_backtrace. Please commit immediately. This is a much-needed fix!

CommentFileSizeAuthor
no_end_php_tag.patch2.1 KBdmitrig01

Comments

jp.stacey’s picture

Hi,

this is my first patch test, so please let me know if this isn't right.

I tested this patch on Drupal HEAD (http://drupal.org/node/28245). Before and after the patch I swept the codebase with:

grep "?>" * -rI | grep -v .tpl.php | grep -v "<?xml"

Prior to the patch there was indeed a set of files with "?>" at the end of them:

includes/database.mysql-common.inc:?>
includes/install.mysql.inc:?>
includes/install.mysqli.inc:?>
includes/install.pgsql.inc:?>

After the patch these were removed from the output of the grep.

The rest of the results returned from the grep were either regular expressions, comments or similar.

The patch installed fine with no errors or line-number warnings.

gábor hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed!

dmitrig01’s picture

jp.stacey - Excellent review!

Anonymous’s picture

Status: Fixed » Closed (fixed)