Enclosure support for Aggregator

Here's a patch for 4.5.2, but this will be implemented way better in 4.6:
http://writtorrent.sourceforge.net/2005/02/rss-20-feeds-with-enclosures-...

antipasto-
this doesnt change the aggragator's ability to parse enclosures... which this request is about.
I am going to look at aggregator.module and see what needs to be done.

Patches should be against CVS HEAD, not against the DRUPAL-4-5 branch.

I think this is fixed in HEAD. Can someone confirm and close this issue?

No, it's still not in the 4.7 branch or HEAD. I am working on something to enable this kinda support.

budda, how is are the changes coming to add enclosure support?

budda: Any news on this issue?

Moving to cvs.

Things got side tracked towards the FeedAPI module, which is being dissected to hopefully go in to Drupal core somehow.

Attached patch brings enclosure support to Aggregator.

Re-roll.

• I am new to this site and not sure where everything supposed to go.
• Reading this site I cannot yet determine where the development focus is with news aggregation so I must assume the core module is where I look first.
• Attached is my PDF with coding details I used to add image enclosure support to Aggregator 6.x

+1
How has this 6 year old feature request never gotten any approval? Or am I missing something?

+1
This seems a bit of a no-brainer addition to the core aggregator. In Drupal7 there doesn't seem to be any other way to achieve the same results either, which I think there is in drupal6

I would also love to see this added in, seems commonplace these days.

Re-roll of patch #12 from cvs to git. Test: update.php and the sample RSS feed with enclosures is here.

This works on my machine - not sure why it doesn't here. In reading, may be the -text on the .tpl.php. Any help appreciated. Thanks.

it appears as though the patch is written for D7. will try to rewrite it for D8

The organisation I work for has a requirement for enclosure utilisation using D8 core aggregator. I have been charged with producing the solution and have produced an extension to core which is being tested internally at my organisation.

We are planning to deploy a local patch today to ensure the changes are retained, which once tested I will post here.

Many thanks,
Christian

Setting to Needs Review to run the testbot on @CFG OCC's patch in #32.

Added latest patch based on feedback from https://www.drupal.org/project/drupal/issues/16485#comment-12620453

Many thanks,
Christian

I have reviewed the patch, fixed a couple of errors with the fetching and saving of enclosure items and updated code formatting to Drupal standards from the codesniffer results.

Thanks,

Stephen

We are updating to Drupal 8.6 and therefore I will re-create this patch for 8.6

Resolving the test failures (and adding new tests to cover the new functionality) will be needed.

1. +++ b/core/modules/aggregator/src/Entity/Item.php
   @@ -115,9 +116,40 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
   +    ¶
   ...
   +  ¶
   
   +++ b/core/modules/aggregator/src/FeedInterface.php
   @@ -19,6 +19,25 @@
   +  ¶
   
   +++ b/core/modules/aggregator/src/ItemInterface.php
   @@ -8,6 +8,14 @@
   +  ¶
   
   @@ -27,6 +35,26 @@ public function getFeedId();
   +  ¶
   

   There are a few whitespace issues in this patch that should be resolved.

2. +++ b/core/modules/aggregator/src/FeedInterface.php
   @@ -19,6 +19,25 @@
   +  public function getSaveEnclosures();
   ...
   +  public function setSaveEnclosures($saveenclosures);
   
   +++ b/core/modules/aggregator/src/ItemInterface.php
   @@ -27,6 +35,26 @@ public function getFeedId();
   +  public function getEnclosure();
   ...
   +  public function setEnclosure($enclosure);
   

   Adding methods to interfaces will be tricky in order to not break BC. One approach is to add a new interface, then have the Feed class implement both the FeedInterface and the new one. And similarly, a new interface for the Item entity to implement too.

Hy,
fist, I'm sorry for my english "so Français" !
I apply the patch but when I update the feed enclosure are getting well, I have the images creates in the enclosure folder but field enclosure in DB still to NULL ...
An idea ?
thank for help ;)

The attached patch defines two new interfaces for aggregator feeds and items that deal with enclosures. It also now saves data to the enclosure DB field.

Using a single DB field for enclosure data is far from ideal because there are a number of things that need to be stored for each enclosure item (the patch stores them as a serialized array). Enclosure data should probably be stored in it's own database table, which likely means implementing enclosures as content entities.

As it stands, this patch will store the URL, type, size and file ID of the enclosure, but this data is only accessible through code (using the getEnclosure() and getEnclosureFile() methods on a feed item). Ideally this data should also be exposed to views so that enclosure media items can be accessed through the UI.

I like the idea @stephen-cox had of supporting enclosure as a content entity. The only question is which kind of entity; a custom entity with fields for the enclosure attributes or a file or media entity where the file is brought into the site where Aggregator is running? With a media/file entity, you could have duplicate content issues and with a custom entity, you have etiquette (and possible security) concerns about linking to a file on someone else's site.

Here's a re-roll of patch #50 with Drupal 9 support.

Updated patch fixing test failures.

Fixed CS issues

Fixing tests.

The aggregator module has been removed from Core in 10.0.x-dev and now lives on as a contrib module.
Issues in the Core queue about the aggregator module, like this one, have been moved to the contrib module queue.

https://docs.laminas.dev/laminas-feed/reader/ (which we use) supports enclosures, and now items are entities, this should be doable - we could add a file field to the item entity and customise the parser

In fact, you could do this on your own without hacking core using existing plugin/entity hooks to modify the parser class and fields.

@larowlan: would be nice to store enclosure URL and maybe other data in aggregator_item table or add method to get this data during import for further processing of imported items.