The Node Secret Preview module allows the editors to generate a preview url for a node.
This url can be sent and accessed by anyone so that also people outside of the website (non users) can check it out.

Project url (sandbox): http://drupal.org/sandbox/ralf57/1648486

Direct clone the project:
git clone --recursive --branch 7.x-1.x ralf57@git.drupal.org:sandbox/ralf57/1648486.git node_secret_preview

Tested in Drupal 7

Comments

iptechlabs’s picture

iptechlabs commented

Welcome,

This project is too short to approve you as git vetted user. This url how much code do we need to approve a user? propose simple rules that can be used to deny the "create full projects" permission (everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed).

Automated Review
http://ventral.org/pareview/httpgitdrupalorgsandboxralf571648486git

ralf57’s picture

ralf57 commented

Thanks,
I was already aware of the "minimum amount of code" rule but the module does the job with just 55 lines of code.
Why should I add more (unneeded) stuff to it?

patrickd’s picture

patrickd commented

This rule is not stating that small modules are not welcome on drupal.org or that you have to add unnecessary stuff to your project.

the problem is simply that this process is about checking whether you can handle the API's correctly and securely before giving you the permission to create random full projects here. - it is simply not possible to seriously review whether you got these skills if there's such less code.

We can promote this project to a full one manually, so you have to come back another time with a *little* larger module

ralf57’s picture

ralf57 commented

the problem is simply that this process is about checking whether you can handle the API's correctly and securely before giving you the permission to create random full projects here

I agree that newcomers have to build a good reputation and trust but my next projects would go under review anyway, right?

We can promote this project to a full one manually, so you have to come back another time with a *little* larger module

My goal is not to show my friends that I have a module on drupal.org.
I developed this small thingy and wanted to contribute to the drupal community. That's it.
I am not pledging the "drupal contributor" role either, if you want the module here just promote it otherwise it will go to github. No problem.

fotuzlab’s picture

fotuzlab commented

"but my next projects would go under review anyway, right?"

@ralf57, getting a module reviewed that has more than 120 lines of code gets you the permission to promote your sandbox projects to full projects. That is a one time exercise. Once you get the permission you would be able to promote your small/big modules, skipping the project application queue. (However its always good to have peer review.)

In case you have another module having more lines of code that you want to get reviewed, you may close this application and start a new one.

"My goal is not to show my friends that I have a module on drupal.org.
I developed this small thingy and wanted to contribute to the drupal community. That's it."

I appreciate!

"if you want the module here just promote it otherwise it will go to github"

It would be a better contribution if this module makes it to DO project page. Moreover it is easier to follow a drupal module on DO than anywhere else.

ralf57’s picture

ralf57 commented

Thanks everyone for taking the time to explain how things work here (even though I do not fully agree).
Could you please promote this module to a full project as patrickd proposed?

martins.bertins’s picture

martins.bertins commented
Status: Needs review » Needs work

Some things I would suggest still working on:
1. There are errors given by the PAReview;
2. In hook_form_alter you could check if $form_id contains 'node_form' to determine if it is a node form and check $form['nid']['#value'] to determine if the user is editing existing node (just a suggestion to your question in code comments);
3. It would be more convenient if the preview URL would be seen when viewing the node, not editing it.

Otherwise, everything worked as intended.
Good luck!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.