Implement hook_requirements and check for required recurly code libraries

Yep, this would be a good idea. Additionally, I think we should prevent Recurly.js and Recurly Hosted Pages from being enabled at the same time, since they're alternatives to each other.

Thanks, I added an extra check into Recurly Hosted to report an error if it's turned on the same time as Recurly.js also.

Committed and pushed.

The Recurly SDK requires cURL, we could also push this in (and I'll take it out of commerce_recurly) since it would actually be better in the core module. Since you just committed #3, I didn't roll a patch. Let me know if you want one.

<?php
function commerce_recurly_requirements($phase) {
  // Skip the requirements check if SimpleTest is installed to avoid multiple
  // cURL rows.
  if (module_exists('simpletest')) {
    return;
  }

  $t = get_t();

  $has_curl = function_exists('curl_init');

  $requirements['commerce_recurly_requirements'] = array(
    'title' => $t('cURL'),
    'value' => $has_curl ? $t('Enabled') : $t('Not found'),
  );

  if (!$has_curl) {
    $requirements['commerce_recurly_requirements'] += array(
      'severity' => REQUIREMENT_ERROR,
      'description' => $t("Commerce Recurly requires the PHP <a href='!curl_url'>cURL</a> library.", array('!curl_url' => 'http://php.net/manual/en/curl.setup.php')),
    );
  }

  return $requirements;
}
?>

Thanks, another good suggestion. :)

I'll put it in when I'm at a stopping point today.

Pushed up a very similar patch: http://drupalcode.org/project/recurly.git/commitdiff/fc2ebc88367a4492c34...

Thanks again!