By default 'You are the current highest bidder is displayed' instead of 'You are not authorized to bid' even if there are no bids.
Only if there's a bid, 'You are not authorized to bid' message is displayed.

CommentFileSizeAuthor
#1 auction_1.patch540 bytesMr Mason

Comments

Mr Mason’s picture

Mr Mason commented
Assigned: Unassigned » Mr Mason
StatusFileSize
new auction_1.patch540 bytes

I found how to fix this. For some reason the module would not catch if you were an anonymous user. All that needed to be done was change line 548 from
if ($high_bid['uid'] == $user->uid ) {
to this
if ($high_bid['uid'] == $user->uid && uid != 0) {

brmassa’s picture

brmassa commented
Assigned: Mr Mason » brmassa
Status: Active » Patch (to be ported)

Guys,

thanks for reporting. its fixed on eC4.

regards,

massa

gordon’s picture

gordon commented
Status: Patch (to be ported) » Fixed

Ported to 5.x-3.x-dev and 4.7.x-3.x-dev

dimsal’s picture

dimsal commented

Well, I tried this fix, but now if I'm a high bidder and logged in, I see 'You may place a bid' instead of 'You're the current high bidder'...
and, as a side effect, a user can now outbid oneself... weird...

Any ideas?

dimsal’s picture

dimsal commented
Status: Fixed » Active

Anyone?

ax’s picture

ax commented

well - apparently, the 10-char-fix has a bug :S there is a syntax error in

&& uid != 0

(or

and !empty(uid)

as committed to the DRUPAL-4-7--3 branch)

which yields a Parse error: syntax error, unexpected ')', expecting T_PAAMAYIM_NEKUDOTAYIM in .../modules/ecommerce/contrib/auction/auction.module on line 482 in my setup (wondering how this got committed ...).

fix: replace uid with $user->uid.

ax’s picture

ax commented
Status: Active » Fixed

i just see that this had been fixed in the DRUPAL-5--4 branch. this fix wasn't backported to the DRUPAL-5--3 and DRUPAL-4-7--3 branches, though. just did that - hope you don't mind.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)