What I see every now and then are translated variable labels. Since it takes an eternity before a correction is accepted by the ever so slow community decision process (everyone is busy with other things), the irritation and annoyance builds up whenever a new site is set up with again the same stupid translated variables that break functionality of the string.

The best way to approach this problem is by preventing it. I therefore suggest here that in the translated string only unchanged variables are accepted. Sometimes a translator or in special cases you want to remove the variable. I therefore suggest that only changed variables and not the removal of them is inhibited at data entry level.

Comments

SebCorbin’s picture

Priority: Critical » Major
Status: Active » Needs work

I agree, though this should not be a requirement and could be implemented as a global setting for example.

SebCorbin’s picture

StatusFileSize
new1.91 KB
SebCorbin’s picture

Status: Needs work » Needs review
guy_schneerson’s picture

Status: Needs review » Needs work

We managed to translate a variable will look into this.

iaugur’s picture

Status: Needs work » Needs review
StatusFileSize
new1.94 KB

The form_set_error() call was being passed a NULL which failed the set error.
Updated to set the form element so the error works and the element is highlighted.

Patch by me and guy_schneerson

Status: Needs review » Needs work

The last submitted patch, 1650188-5-l10n_server.patch, failed testing.

guy_schneerson’s picture

The problem is with plurals where those may not include the original variable.

iaugur’s picture

Status: Needs work » Needs review
StatusFileSize
new1.94 KB

We have updated the validation to check for plurals and check translated plurals against their corresponding source.

Status: Needs review » Needs work

The last submitted patch, 1650188-8-l10n_server.patch, failed testing.

iaugur’s picture

Status: Needs work » Needs review
StatusFileSize
new2.2 KB

Resubmitted patch

SebCorbin’s picture

Status: Needs review » Fixed

Aaaaand committed! Great work guys :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.