What I see every now and then are translated variable labels. Since it takes an eternity before a correction is accepted by the ever so slow community decision process (everyone is busy with other things), the irritation and annoyance builds up whenever a new site is set up with again the same stupid translated variables that break functionality of the string.
The best way to approach this problem is by preventing it. I therefore suggest here that in the translated string only unchanged variables are accepted. Sometimes a translator or in special cases you want to remove the variable. I therefore suggest that only changed variables and not the removal of them is inhibited at data entry level.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 1650188-10-l10n_server.patch | 2.2 KB | iaugur |
| #8 | 1650188-8-l10n_server.patch | 1.94 KB | iaugur |
| #5 | 1650188-5-l10n_server.patch | 1.94 KB | iaugur |
| #2 | 1650188-2-l10n_server.patch | 1.91 KB | SebCorbin |
Comments
Comment #1
SebCorbin commentedI agree, though this should not be a requirement and could be implemented as a global setting for example.
Comment #2
SebCorbin commentedComment #3
SebCorbin commentedComment #4
guy_schneerson commentedWe managed to translate a variable will look into this.
Comment #5
iaugur commentedThe form_set_error() call was being passed a NULL which failed the set error.
Updated to set the form element so the error works and the element is highlighted.
Patch by me and guy_schneerson
Comment #7
guy_schneerson commentedThe problem is with plurals where those may not include the original variable.
Comment #8
iaugur commentedWe have updated the validation to check for plurals and check translated plurals against their corresponding source.
Comment #10
iaugur commentedResubmitted patch
Comment #11
SebCorbin commentedAaaaand committed! Great work guys :)