I sat down today to work on adding XML export functionality to Views Export module, and found that this is going to be incredibly tedious with all the various permission checking for "export views as X" permissions everywhere.

Proposal: make it just "export views" permissions, and then limit to specific roles in the access permissions on the view itself. Patch coming up.

CommentFileSizeAuthor
#1 views_bonus-permissions-165067-1.patch4.04 KBwebchick

Comments

webchick’s picture

Status: Active » Needs review
StatusFileSize
new4.04 KB

I should point out I ran this idea past Earl and he approves. Here's the patch.

webchick’s picture

Oh, I should explain some of this.

I took out the permission checking in a few of these functions, because this is already done for you in hook_menu, so it is redundant to do it twice.

robloach’s picture

Status: Needs review » Needs work

Whoops... It seems you're using HEAD instead of DRUPAL-5. There was a major overhaul in the DRUPAL-5 branch that fixed the design a bit. It would be good to merge this patch with that branch though, of course.

Should there be a note in HEAD stating that DRUPAL-5 is the latest branch?

robloach’s picture

Assigned: Unassigned » robloach

I'll merge them today, no worries. Thanks a lot!

robloach’s picture

Version: 6.x-1.x-dev » 5.x-1.x-dev
Status: Needs work » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)