Spin-off from #1507960: [meta] Isolate and/or remove IE-specific hacks in core markup, CSS and JavaScript and #1465948: [meta] Drop some IE8 coddling from Drupal core.

I grepped HEAD for CSS files containing the words "Microsoft" or "filter:", and found only toolbar.css. Here's a clean up of that. It means IE8 users will not see a drop shadow below the toolbar, but based on discussions in those meta issues, I think that's ok for D8.

This also removes the moz and webkit versions of box-shadow, because I think all modern versions of those browsers support box-shadow itself at this point.

CommentFileSizeAuthor
#1 1651270-IE8.jpg87.43 KBnod_
remove-ie8-box-shadow-hack.patch2.69 KBeffulgentsia

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +JavaScript clean-up
StatusFileSize
new 1651270-IE8.jpg87.43 KB

IE8 toolbar screenshot

Height adjustments works for body displacement and tableheader. All good. Tested on the real IE8 not the emulated from IE9/10.

effulgentsia can you add the JS clean-up tag to those issues please? it helps :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

droplet’s picture

droplet commented 
+++ b/core/modules/toolbar/toolbar.cssundefined
@@ -39,11 +39,7 @@ body.toolbar-drawer {
-  -webkit-box-shadow: 0 3px 20px #000;

recall my memory. we only drop -webkit-border-radius. All android version need the prefixes.

aspilicious’s picture

aspilicious commented

http://www.w3schools.com/cssref/tryit.asp?filename=trycss3_box-shadow

We don't need the -webkit prefix anymore for box shadow apparantly. :D
Certainly not in 2013 ;)

droplet’s picture

droplet commented

Sure, I don't want it back too. But randomly remove stuff is not good. There many -webkit prefix still exist in CORE. Will you add an follow up issue? (remove all) Without an announce, some other issues may add it back.

droplet’s picture

droplet commented

#1664268: Drop some browser specific prefixes

aspilicious’s picture

aspilicious commented

There are not many -webkit prefixes left, I commented in the linked issue.

Automatically closed -- issue fixed for 2 weeks with no activity.