It would be super awesome to have a specific permission for respond.js rather than the generic "access administration pages."

CommentFileSizeAuthor
#4 1651308-4-respondjs-admin-perm.patch867 bytesrupl
#3 1651308-3-respondjs-admin-perm.patch865 bytesrupl

Comments

rupl’s picture

rupl
he/him
Primary language English
commented

What kind of permission should exist? Just an admin flag specific to the module?

I can't imagine a front-facing permission at the moment, but I'm definitely open to ideas!

pixelwhip’s picture

pixelwhip commented

I was just thinking an admin side permission to restrict access to the 'admin/config/media/respondjs' specifically. Nothing crazy.

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 1651308-3-respondjs-admin-perm.patch865 bytes

kk, what about this?

rupl’s picture

rupl
he/him
Primary language English
commented
StatusFileSize
new 1651308-4-respondjs-admin-perm.patch867 bytes

Missed parens in the comment.

pixelwhip’s picture

pixelwhip commented
Status: Needs review » Reviewed & tested by the community

This worked perfect. Code also looks good. Thanks for jumping on this so quickly.

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Ok, committed to dev! I'll probably tag another release soon. We've got a couple nice improvements in the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

yesct’s picture

yesct commented

Glad to see this is in dev. I was just about to open an issue for it.

rupl’s picture

rupl
he/him
Primary language English
commented

Yup, expect a release next week at DrupalCon :)

rupl’s picture

rupl
he/him
Primary language English
commented
Title: Add a user permission » Add a custom user permission: "administer respondjs"

Renaming this issue for clarity since I'm referencing it in another issue.