When moving update_status into D6 as update.module (http://drupal.org/node/94154), Dries pointed out that admin/logs/* didn't seem like an obvious place to look for the available updates page, but I pointed out it's right next to the status report. We agreed that renaming this section of the admin menu to be "admin/reports" makes much more sense. The log pages you get to from there all seem like reports already ("Top pages", "Recent log entries", "Recent hits", etc), and the "Status report" and "Available updates" fit more naturally.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Michelle’s picture

+1 from me. I'm all for giving the menus clearer names and reports is much better, IMO.

Michelle

yoroy’s picture

+1. Reports is much better. Less geeky and just a better term for what you'll find there.

dww’s picture

Component: system.module » base system
Assigned: Unassigned » dww
Status: Active » Needs review
FileSize
29.07 KB

This patch assumes you've already applied the fix for http://drupal.org/node/176805. If you don't apply that first, you'll get a single hunk that fails against update.php, but that's minor and can basically be ignored if you still want to review/test everything else.

Also, please note that this patch does *not* fix http://drupal.org/node/139015. I'll re-roll that patch when/if this one lands.

hass’s picture

Status: Needs review » Needs work

use url() or l() for urls index.php?q=admin/reports/dblog or basepath may not work.

hass’s picture

and try to move URLs out of translatable strings and replace them with url placeholders...

dww’s picture

Status: Needs work » Needs review

@hass: your review is of the wrong patch, but i see you commented in http://drupal.org/node/176805, too, which is where this code originates. setting this back to needs review, since everything else in here is still valid.

hass’s picture

Status: Needs review » Needs work

this patch contains such a link, too.

-    $log_message = ' All errors have been <a href="index.php?q=admin/logs/dblog">logged</a>.';
+    $log_message = ' All errors have been <a href="index.php?q=admin/reports/dblog">logged</a>.';
dww’s picture

Status: Needs work » Needs review
FileSize
29.08 KB

Here's a new patch based on the latest from http://drupal.org/node/176805

@hass: for the 3rd time...

This patch assumes you've already applied the fix for http://drupal.org/node/176805. If you don't apply that first, you'll get a single hunk that fails against update.php, but that's minor and can basically be ignored if you still want to review/test everything else.

*sigh*

Please either understand the issues and the patches, or leave them alone. Thanks.

Gábor Hojtsy’s picture

176805 is resolved now, so this patch can stand on its own.

While I am fine with renaming admin/logs to admin/reports, it can be taken as a usability / simplification fix. I am not sure it is the best idea to do it now, but if carefully done, it could work well, IMHO. Still, if I were dww, I would wait for Dries to approve :)

dww’s picture

Thanks for committing that other patch, Gabor, makes this one easier to work with. Yup, #8 still applies (with minor offsets). But yeah, let's see what Dries has to say about this... ;)

rstamm’s picture

Status: Needs review » Needs work

patch #8 patched function system_update_177()

rstamm’s picture

Status: Needs work » Needs review
FileSize
26.11 KB

patch rerolled.

dww’s picture

@Ralf, thanks good catch. However, we're still waiting for Dries to at least comment here about his intentions before I spend any more time getting reviews and tests for this. I'm tired of wasting time on core patches that aren't going to be committed.

rstamm’s picture

this improves the usability, I hope it gets in soon.

Gábor Hojtsy’s picture

Discussed this with Dries and we agree that this should be brought forward. It will be committed. Needs testing still.

dww’s picture

Title: Usability and string freeze: rename admin/logs to admin/reports » beta3 blocker: Usability and string freeze: rename admin/logs to admin/reports
Priority: Normal » Critical

Great, glad to see it's going to get committed. #12 still applies (with minor fuzz) and in my testing seems to work fine. Obviously, we could use some other testers and reviewers in here. If this is going to make it in for D6, we need to bump the visibility and priority of this, to hopefully get more eyes on the patch...

JirkaRybka’s picture

FileSize
26.04 KB

Re-rolled to remove the fuzz, otherwise the same patch.

I read the patch file, did a fresh 6.x-dev install with the patch applied, enabled all modules affected by the patch, and browsed all logs/reports pages and other admin pages which I thought may be related, checking for links to logs/reports working. All fine, and no more places to be updated, as far as I can see (which is NOT all pages existing in the UI, no time to check all).

I think this may be RTBC, but preferrably with some more review.

ChrisKennedy’s picture

FileSize
28.05 KB

I grepped through the Drupal source and found one minor admin/logs reference in system.install that needed to be converted.

dww’s picture

@ChrisKennedy: That's exactly what comment #12 was about. You (re)changed system_update_177(), but at the time system_update_177() runs, it is still going to be admin/logs, not admin/reports.

So, #18 should be ignored, #17 is our current patch to review...

ChrisKennedy’s picture

Status: Needs review » Reviewed & tested by the community

dww: ah, sorry about that, should have read the issue more thoroughly.

Anyway, I tested a D5 -> D6 upgrade and the relevant links for #17; everything worked fine.

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Needs work

Thanks, committed. The update docs need to have this change listed, so marking as code needs work.

ChrisKennedy’s picture

Status: Needs work » Fixed
dww’s picture

Excellent, thanks folks!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.