It would be quite handy to let group options handle the recently added ’corner styles’ feature. As I saw it is a simple addon to the ad code: google_ui_features = "rc:n"; where n is 0, 6 or 10. I might be wrong I didn't spend too much time investigating.

CommentFileSizeAuthor
#8 adsense.ui_feature.diff2.43 KBdennys
#7 adsense_ui_feature_result.gif2.06 KBdennys
#7 adsense.ui_feature.diff2.58 KBdennys
#5 adsense.ui_feature.diff2.14 KBdennys
#5 adsense_ui_feature_setting.gif9.41 KBdennys
#5 adsense_ui_feature_result.gif4.89 KBdennys

Comments

melon’s picture

melon commented

I wonder if anyone still interested in this feature? Or do I need to code it myself ;)

crapufish’s picture

crapufish commented

I would like to see it implemented as well! :)

kbahey’s picture

kbahey commented

As always features get implemented if someone writes a patch.

So, let us see a TESTED patch and I will include it.

David Latapie’s picture

David Latapie commented

I am interested too!

dennys’s picture

dennys commented
Status: Active » Needs review
StatusFileSize
new adsense_ui_feature_result.gif4.89 KB
new adsense_ui_feature_setting.gif9.41 KB
new adsense.ui_feature.diff2.14 KB

I wrote a patch for it, please help to review, thanks.

kbahey’s picture

kbahey commented
Status: Needs review » Needs work

Good work.

But, I think that it is much better to add a drop down list, and fill in the "rc:" part automatically, rather than rely on manually typing something non-obvious?

Also add a more descriptive "#description". Just saying UI feature is confusing.

dennys’s picture

dennys commented
Status: Needs work » Needs review
StatusFileSize
new adsense.ui_feature.diff2.58 KB
new adsense_ui_feature_result.gif2.06 KB

I modified the code, please help to check it, thanks. Btw, I'm not sure what to write in description, is there any suggestion?

dennys’s picture

dennys commented
Version: 5.x-1.x-dev » 5.x-1.6
StatusFileSize
new adsense.ui_feature.diff2.43 KB

Sorry, there is a bug for the new dropdown list. It can save, but it cannot "show" correct value. It's fixed now.

plantucha’s picture

plantucha commented

patch works for me.
Thanks

dennys’s picture

dennys commented

@kbahey:

It this patch ok? Could you help to review it, thanks.

druvision’s picture

druvision commented

Tried to apply the patch against adsense-5.x-2.0 - This first 3 hunks succeeded, the 4th failed, but even after I've manually applied it, there is no changed on the GUI of the adsense module.

kbahey’s picture

kbahey commented
Version: 5.x-1.6 » 5.x-2.x-dev
Status: Needs review » Needs work
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Fixed

This was added to the 5.x-3.x and 6.x-1.x branches a long, long time ago.

Marking it fixed to let it close automatically in two weeks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.