Cache and Redirection Problem

This queue is about Simplenews, not Simpleads. Redirecting.

I have the same issue... I have 4 ads 3 or them work and the 4th one doesn't. Needs a rapid fix..

Please give this module a try http://drupal.org/project/cacheexclude (I haven't test it myself).

Changing this line: header("Location: " . $url); to drupal_add_http_header('Location', $url); seemed to fix the bug for me.

Patch attached.

Edit: that was against 7.x-1.x-dev

#5: cache-redirect-1652880-5.patch queued for re-testing.

Err...I'm guessing the TestBot doesn't work for contrib. Sorry for the flood.

No problem, once someone else confirm this patch works then I will apply it manually.
Thanks for sharing this.

#5 fixed the issue for me as well.

#5 did the trick for me, too

This works with drupal cache, but it doesn't work if you're using the boost module.

I'm wondering why header() is used for redirection at all. Changing it to drupal_goto() fixed the issue in Boost as per #1176534: Bypass caching on redirects. Please test with core caching, patch attached.

See also #1555988: Memcache problems on redirect?

The issue is in the business logic behind what is going on. Most users ads probably link to external pages so why would an administrator want to view the ad node when clicking his own ads? I removed this piece and changed it so that it simply does not record clicks for administrators but still redirects the user.

Replace the code at line 399 with this:

if (!user_access('administer nodes') && !user_access('access ad node')) {
// Only save the click for non administrators
_simpleads_save_click($node);
}
$url = _simpleads_validate_url($url);
module_invoke_all('simpleads_redirect', $url, $delta);

http://www.minus-reality.com

Please try install development release. Similar issue: #1555988: Memcache problems on redirect?

Duplicate of #1555988: Memcache problems on redirect?