per my point in #1546110-27: Revisit syncEvent() logic on main repository sync plugin, i am worried that our current logic may cause OOM on large repos when new branches are pushed. we should test this with a core repo and if it fails consistently, attempt the array_chunk() route immediately. if it does not fail or fails intermittently, we can tackle it after we make a new release and deploy to d.o.

CommentFileSizeAuthor
#4 1653276.patch2.28 KBdrumm

Comments

eliza411’s picture

eliza411 commented
Issue tags: +git deployment blocker

tagging

marvil07’s picture

marvil07 commented
Issue tags: -git deployment blocker +vc-next

To next version
(during triage)

marvil07’s picture

marvil07 commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Issue summary: View changes

Self note: Most of the time this happens on repository's loadCommits(), look for that.

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm
Status: Active » Needs review
Issue tags: +affects drupal.org
Related issues: +#3078948: Git tags not available for new release creation
StatusFileSize
new 1653276.patch2.28 KB

#3078948: Git tags not available for new release creation ran into this issue. This patch should work well to resolve it.

  • marvil07 committed ef82e84 on 7.x-1.x authored by drumm 
    Issue #1653276 by drumm: Load commits in chunks on syncEvent() to...
marvil07’s picture

marvil07 commented
Status: Needs review » Fixed

@drumm, thank you for implementing this!

The change looks great (especially with --ignore-all-space), we have used that pattern in other places already, and tests pass correctly.

I have added this to 7.x-1.x.
It feels so good to close a 7years issue :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.