Looking through the code, the 'page_cache_fastpath' variable seems redundant to me. Why is it there? It seems to be a way to manually disable the file cache? But why do it that way, rather than simply disabling the module? I don't see it buying us anything except to further confuse the code.
Moshe, you've been looking at this code recently -- any feedback?
Comments
Comment #1
jeremy commentedOkay, so now I remember that 'page_cache_fastpath' tells Drupal to try and serve pages without loading the rest of Drupal (allowing things like serving pages directly from the filesystem even when MySQL is down). That said, the checks in the code seem to be broken logic -- ie, the garbage collection needs to happen whether or not that variable is set, as if this module is enabled and configured, pages are being served from the cache.
Comment #2
moshe weitzman commentedi agree that the code got confusing at times. i didn't really think about this deeply during my port.
Comment #3
kenorb commentedComment #4
kenorb commented