Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
update.module
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
8 Aug 2007 at 18:05 UTC
Updated:
24 Sep 2007 at 18:21 UTC
Jump to comment: Most recent file
If there is still time to improve 2.0 version a little bit, i would suggest changing line 945:
$output .= ' <span class="check-manually">'. l(t('Check manually'), 'admin/logs/updates/check') .'</span>';
to
$output .= ' <span class="check-manually">('. l(t('Check manually'), 'admin/logs/updates/check') .')</span>';
(see added parenthesis after <span>)
This will enhance the output a little bit, because now the output is "XY minutes ago Check manually" and will be "XY minutes ago (Check manually)"
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | update_check_manually_after.png | 126.97 KB | dww |
| #3 | update_check_manually_before.png | 132.31 KB | dww |
| #2 | update_check_manually_usability_165638.patch.txt | 1.98 KB | dww |
Comments
Comment #1
meba commentedComment #2
dwwGood point. I also added some padding via CSS, so it's not so crammed together. Committed to DRUPAL-5--2.
Moving this into the core issue queue for a similar fix for the update.module. Attached patch applies cleanly against HEAD, and handles both LTR and RTL .css. Should be RTBC, but if someone else wants to take a quick look, that'd be nice. I'll attach screenshots of before and after in the next followups.
Comment #3
dwwScreenshot of before the patch.
Comment #4
dwwScreenshot with the patch.
Comment #5
meba commentedGreat!
Comment #6
dwwStill applies cleanly without offsets. Doesn't effect t() strings. Includes both LTR and RTL .css. I know it's my own patch, but this is RTBC.
Comment #7
gábor hojtsyGreat improvement. Thanks, committed.
Comment #8
(not verified) commented