similar as case in http://drupal.org/node/165766: we are specifying a unique key with field "name", where "name" is allow null. i have check profile.module INSERT and UPDATE handling, and found that we already have unique checking during form submit. we will only need to update its schema.

P.S. it is check with both MySQL and DB2, and all passed :)

CommentFileSizeAuthor
drupal-6.x-dev-profile.schema-0.1.diff941 byteshswong3i

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Thanks, committed!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
bjaspan’s picture

bjaspan commented
Status: Closed (fixed) » Needs work

This patch introduces a core schema discrepancy.

profile_schema declares () profile_fields.name to have default '' but profile.install:1.1 (D5's version) created the column as "default NULL" (i.e. no default, but nullable). As a result, after updating D5 to D6, there is a mismatch. Which is right? I think "no default, not null" is semantically correct as you cannot have a profile field without a name, but I'm not certain.

bjaspan’s picture

bjaspan commented
Status: Needs work » Fixed

This is fixed by my patch in http://drupal.org/node/173982.

hswong3i’s picture

hswong3i commented

@bjaspan: sorry for introducing this inconsistence, and thank you for your kindly help :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)