Since it stores the item's body text, it ought to be called body, rather than description.

I filed under 6, as this seems like a clear over-sight, but in case it's too major to fix there, please re-file against 7.

CommentFileSizeAuthor
#5 165786_aggregator_rename_description_column_to_body.patch4.76 KBmaartenvg
#2 aggregator_item_description_to_body.patch5.99 KBmaartenvg

Comments

chx’s picture

chx commented
Version: 6.x-dev » 7.x-dev
maartenvg’s picture

maartenvg commented
StatusFileSize
new aggregator_item_description_to_body.patch5.99 KB

Created a patch for this, and seems to work fine.

The only problem I have is that I couldn't get the aggregator_update_7001() to be detected during the running of update.php (even though {system} says that the schema_version is 7000). Or should I have added it to system.install? (fixed by separate issue)

maartenvg’s picture

maartenvg commented
Status: Active » Needs review

double post

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

maartenvg’s picture

maartenvg commented
Status: Needs work » Needs review
StatusFileSize
new 165786_aggregator_rename_description_column_to_body.patch4.76 KB

Chasing HEAD, it failed due to the DB-TNG. Added comment to aggregator_update_7001().

dries’s picture

dries commented

I'm not sure about this one. It is actually called 'description' in the RSS specification. I don't know at the top of my head what it is called in the Atom specification. If it is called 'body' in the Atom specification, this patch might fly.

maartenvg’s picture

maartenvg commented

For atom is appears to be "content", so neither 'description' or 'body'.

Status: Needs review » Needs work

The last submitted patch failed testing.

Crell’s picture

Crell commented
Component: database system » aggregator.module

I don't see how this is a DB system issue. It's part of aggregator module. I defer to those folks as to whether or not it's still relevant, as I know a lot of work went into that module in Drupal 7.

Crell’s picture

Crell commented

Given the work that's gone into Drupal 8's aggregator module, is this issue even still relevant? I would think not...

mimes’s picture

mimes commented

It's still an issue for Drupal 7's aggregator module, though. aggregator_item.description is still described as "body of the feed item".

Crell’s picture

Crell commented

Yes, but we can't rename the field in Drupal 7 at this point, and I don't think it even exists in the same form in Drupal 8. So is this a won't fix?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue summary: View changes
Status: Needs work » Closed (works as designed)

It still exists in the same way but I don't really see the point in doing this.

Just like the GUID, description is something used in RSS and possibly other feed standards.