Download & Extend

DB Silliness: aggregator_item.description ought to be called body

Project:Drupal core
Version:7.x-dev
Component:aggregator.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

Since it stores the item's body text, it ought to be called body, rather than description.

I filed under 6, as this seems like a clear over-sight, but in case it's too major to fix there, please re-file against 7.

Comments

#1

Version:6.x-dev» 7.x-dev

#2

Status:active» needs review

Created a patch for this, and seems to work fine.

The only problem I have is that I couldn't get the aggregator_update_7001() to be detected during the running of update.php (even though {system} says that the schema_version is 7000). Or should I have added it to system.install? (fixed by separate issue)

AttachmentSizeStatusTest resultOperations
aggregator_item_description_to_body.patch5.99 KBIdleFailed: Failed to apply patch.View details | Re-test

#3

double post

#4

Status:needs review» needs work

The last submitted patch failed testing.

#5

Status:needs work» needs review

Chasing HEAD, it failed due to the DB-TNG. Added comment to aggregator_update_7001().

AttachmentSizeStatusTest resultOperations
165786_aggregator_rename_description_column_to_body.patch4.76 KBIdleFailed: Failed to apply patch.View details | Re-test

#6

I'm not sure about this one. It is actually called 'description' in the RSS specification. I don't know at the top of my head what it is called in the Atom specification. If it is called 'body' in the Atom specification, this patch might fly.

#7

For atom is appears to be "content", so neither 'description' or 'body'.

#8

Status:needs review» needs work

The last submitted patch failed testing.

#9

Component:database system» aggregator.module

I don't see how this is a DB system issue. It's part of aggregator module. I defer to those folks as to whether or not it's still relevant, as I know a lot of work went into that module in Drupal 7.

nobody click here