Closed (fixed)
Project:
Quotes
Version:
5.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
9 Aug 2007 at 06:18 UTC
Updated:
21 Apr 2008 at 16:56 UTC
Jump to comment: Most recent file
quotes.install does not correctly setup a PostgreSQL-Database. For column 'nid' in table 'quotes_blocks' type INTEGER is used and later a Sequence is created. However, the correct behaviour to have postgre use a Sequence on the column is to use the type 'serial".
The Attached Diff will change this behaviour.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | quotes-install_2.patch | 1.64 KB | fantux |
| #2 | quotes-install_1.patch | 1.64 KB | fantux |
| #1 | quotes-install_0.patch | 2.13 KB | fantux |
| quotes-install.patch | 1.64 KB | fantux |
Comments
Comment #1
fantux commentedI'm sorry, the previous diff was incorrect. It fixed only one of the problems present.
This one should be correct. I also removed the drop-statement dor the sequence in quotes_uninstall. The sequence is now created implicitly and postgre takes care of removing it when the table os dropped.
Comment #2
fantux commentedI'm sorry, the previous diff was incorrect. It fixed only one of the problems present.
This one should be correct. I also removed the drop-statement dor the sequence in quotes_uninstall. The sequence is now created implicitly and postgre takes care of removing it when the table os dropped.
Comment #3
fantux commentedI'm sorry, the previous diff was incorrect. It fixed only one of the problems present.
This one should be correct. I also removed the drop-statement dor the sequence in quotes_uninstall. The sequence is now created implicitly and postgre takes care of removing it when the table os dropped.
Comment #4
nancydruUpdating status to show patch available.
@fantux: This is not a patch format that is typically used. Please use "diff -u -p".
See also: http://drupal.org/node/155886
Comment #5
nancydruDoes this look right?
Comment #6
nancydruFix committed.
Comment #7
nancydru