I find it very undescriptive when I recieve a message from Drupal with the subject "message from username".

This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away.

Oh, and it helps group the 'conversation' on Gmail into something meaningful.

(Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it).

CommentFileSizeAuthor
#12 Drupal.fix-contact-module-ws.patch1.42 KBGábor Hojtsy
contact.module-subject.patch1.93 KBkbahey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kbahey’s picture

kbahey CreditAttribution: kbahey commented

Did this patch make it? Any objections to it?

Dries’s picture

Dries CreditAttribution: Dries commented

I'll commit this patch when there is more demand for it.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented

I'd like to see this applied. An email got to have a subject.

kbahey’s picture

kbahey CreditAttribution: kbahey commented

This is badly needed.

Just today I got a message from walkah and Gmail grouped it in a previous conversation with someone else, just because the subject is "message from kbahey".

We have to get this to CVS.

Morbus Iff’s picture

Morbus Iff
they/them
CreditAttribution: Morbus Iff commented

+1 from me.

tangent’s picture

tangent CreditAttribution: tangent commented

There is an added newline in the foreach which seems unnecessary. Some lines also have tabs which disrupts the indentation.

Otherwise, +1 on the functionality.

Anonymous’s picture

(not verified) CreditAttribution: commented

+1 from me too. Since this is a simple useability extension, I hope that it will get into 4.6.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

The previous 'me' was me :)

Dries’s picture

Dries CreditAttribution: Dries commented

Committed to HEAD.

kbahey’s picture

kbahey CreditAttribution: kbahey commented

I think we missed something in this patch.

The form_textfield has an argument that the maximum is 8 characters.
This is too short. Should be 30 characters or more. Line 125 in HEAD.

Dries’s picture

Dries CreditAttribution: Dries commented

Fixed in HEAD. Thanks.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
FileSize
Drupal.fix-contact-module-ws.patch1.42 KB

Whitespace fixes after the patch...

Steven’s picture

Steven CreditAttribution: Steven commented

Seems this last patch was also applied by Dries...

Anonymous’s picture

(not verified) CreditAttribution: commented