ffmpeg_helper patch: Improve error checking in video_render.php [#165948]

When converting to FLV, video_render.php only tests that the FLV file exists after running ffmpeg. However, if ffmpeg happens to segfault, it may have left a zero-byte output file.

This is a simple patch to check that the output file is of non-zero size, in addition to checking that it exists.

Thanks.

Comment	File	Size	Author
#2	video_render.php__1.patch	652 bytes	stmind
#1	video_render.php__0.patch	471 bytes	stmind
	video_render.php_.patch	473 bytes	stmind

Comments

Comment #1

stmind commented 9 August 2007 at 16:47

Status	File	Size
new	video_render.php__0.patch	471 bytes

WRONG PATCH

I attached the wrong patch. Please use this one.

Comment #2

stmind commented 9 August 2007 at 19:19

Status	File	Size
new	video_render.php__1.patch	652 bytes

In further testing, I found another bug in video_render.php (line 94). There is a transposed closing paren in the watchdog call.

    watchdog('video_render', t('video conversion failed. ffmpeg reported the following output: ' . $command_output, WATCHDOG_ERROR));
# should be 
    watchdog('video_render', t('video conversion failed. ffmpeg reported the following output: ' . $command_output), WATCHDOG_ERROR);

I'm attaching a revised patch that fixes both issues.