For anyone how has optomized their site and included all the scripts just before the tag, the module seems to append Shadowbox.init to $page_bottom, before the jQuery libray is loaded. Only quick solution I see is to hard code it into html.tpl.

Shadowbox.init shoud be appended to $scripts variable instead..

CommentFileSizeAuthor
#5 shadowbox-js_optimization_problem-1659716-5.patch462 bytesmanfer
#2 shadowbox-js_optimization_problem-1659716-2.patch463 bytesmanfer

Comments

danny englander’s picture

danny englander
(he/him)
commented

I just ran into this issue as well, I too have my <?php print $scripts; ?> tag right before the closing </body> tag so my Shadowbox is breaking. if I move the scripts tag back to , shadowbox works fine.

There's a lot of advantages to having the scripts tag at the end so it would be nice to have Shadowbox play along. I guess this is not as much of a bug report as a feature request then but I won't change the category yet.

manfer’s picture

manfer commented
Status: Active » Needs review
StatusFileSize
new shadowbox-js_optimization_problem-1659716-2.patch463 bytes
danny englander’s picture

danny englander
(he/him)
commented

Thanks, the patch worked against this version.

manfer’s picture

manfer commented
Version: 7.x-3.0-beta8 » 7.x-4.x-dev
Status: Needs review » Needs work

Pushed on 7.x-3.x version. Same needed in 7.x-4-x version

manfer’s picture

manfer commented
Status: Needs work » Needs review
StatusFileSize
new shadowbox-js_optimization_problem-1659716-5.patch462 bytes
manfer’s picture

manfer commented
Status: Needs review » Fixed

Pushed on 7.x-4.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 543ff82 on 7.x-4.x, 8.x-1.x by manfer: 
    Issue #1659716 by manfer: Fixed javascript optimization problem