For anyone how has optomized their site and included all the scripts just before the tag, the module seems to append Shadowbox.init to $page_bottom, before the jQuery libray is loaded. Only quick solution I see is to hard code it into html.tpl.
Shadowbox.init shoud be appended to $scripts variable instead..
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | shadowbox-js_optimization_problem-1659716-5.patch | 462 bytes | manfer |
| #2 | shadowbox-js_optimization_problem-1659716-2.patch | 463 bytes | manfer |
Comments
Comment #1
danny englanderI just ran into this issue as well, I too have my
<?php print $scripts; ?>tag right before the closing</body>tag so my Shadowbox is breaking. if I move the scripts tag back to , shadowbox works fine.There's a lot of advantages to having the scripts tag at the end so it would be nice to have Shadowbox play along. I guess this is not as much of a bug report as a feature request then but I won't change the category yet.
Comment #2
manfer commentedComment #3
danny englanderThanks, the patch worked against this version.
Comment #4
manfer commentedPushed on 7.x-3.x version. Same needed in 7.x-4-x version
Comment #5
manfer commentedComment #6
manfer commentedPushed on 7.x-4.x