Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
theme system
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
9 Aug 2007 at 21:20 UTC
Updated:
16 May 2009 at 22:14 UTC
Jump to comment: Most recent file
Comments
Comment #1
keith.smith commentedThis is a feature request, so bumping to 7.x
Comment #2
mcjim commentedUpdated patch to work with latest version of HEAD.
I'm fairly new to these things, but as $body_classes is fairly easy to manipulate, though, should we be adding another variable to the mix?
Comment #3
robin monks commentedKeeping in sync with head.
Comment #5
mcjim commentedChasing head.
Comment #7
lilou commentedTest failure : #335122: Test clean HEAD after every commit
Comment #8
mr.baileysI agree with McJim (#2), should we really add
body_classes_arraywhen we already havebody_classes?The way I see it:
body_classes-string is relatively easy to manipulate should themers really want to do this, either through regexes or explode/split/implode. Something likein the theme layer should do the trick, no?
@jjeff (or someone else): can you elaborate a bit on how this could be used?
Comment #9
mr.baileysMarking this quick fix since the change is trivial and unlikely to break anything.
Comment #10
cburschkaThe code style is fine and this will break nothing, and I'm the second reviewer, so I am tentatively marking it RTBC.
However, we haven't solved the question of whether this is a useful feature.
Comment #11
webchickThat means it's not quite RTBC yet. Maybe ping some folks in #drupal-design or #drupal-themes tomorrow.
Comment #12
dvessel commentedWouldn't this qualify as a dupe of #306358: Add $classes to templates with new theme_process_hook functions.
Comment #14
johnalbinYep.