Any plans to port to Drupal 6.x?

CommentFileSizeAuthor
#6 smileys.patch24.43 KBnaheemsays

Comments

Gurpartap Singh’s picture

Not yet (although the api is frozen). There's no release out yet, even not the unstable betas or release candidates.

jmarki’s picture

Any updates on this?

dennys’s picture

subscribing

ilbeppe’s picture

Subscribing

Roxpace’s picture

What is the status of this ?

naheemsays’s picture

StatusFileSize
new24.43 KB

I have gone ahead and done most of the porting. Only thing that remains is a little beyond me. From coder:

Line 129: new hook_theme() function is required to register theme_ functions (Drupal Docs)

function theme_smileys_select_table($promoted = false) {

The patch also gives a few errors per page, but i assume it is because of me not doing the above. I would love it is someone could complete this.

Attached patch is against 5.x-1.x-dev (last updated 26 January)

Smileys_import is totally ported and most of the smileys module is too (along with code cleanups as suggested by coder.module).

(schema.module did nto work for me, so I had to handcode the schema - there are differences to Drupal 5.x - the id is serial(auto increment) and two fields have a bytesize of 4 instead of 1. The latter, I do not know how to change it to one... but this does not break anything. I also removed the updates as one of the functions called by them to change the data to utf8 has been ermoved in Drupal - l am assuming that if someone is updating, they have the latest smileys for Drupal 5.x installed already...)

Can someone please finish this off? there is not much left, but what is is beyond me.

Gurpartap Singh’s picture

Status: Active » Needs review
dennys’s picture

I added this patch but got the error message, my environment is Drupal 5.7.

# warning: Invalid argument supplied for foreach() in \drupal6\includes\menu.inc on line 258.
# warning: Invalid argument supplied for foreach() in \drupal6\includes\menu.inc on line 258.
# warning: array_merge() [function.array-merge]: Argument #1 is not an array in \drupal6\includes\menu.inc on line 323.
# warning: Missing argument 1 for drupal_get_form() in \drupal6\includes\form.inc on line 69.
# warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, '' was given in \drupal6\includes\form.inc on line 358.
naheemsays’s picture

Status: Needs review » Needs work

yep, as mentioned, there one change needed which I could not figure out how. The theme function on around 129 needs to be ported. There may be other errors too which I missed, but I guess they will only be clear after this function is ported.

PS Are you sure your environment is Drupal 5.7? this patch is for Drupal 6.x and your error message suggests drupal 6.x too.

dennys’s picture

Sorry, I'm using 6.1. Because I got these messages on setting, I cannot test it. Is there any suggestion?

naheemsays’s picture

Apart from these messages (on every page), it DOES work for me.

Go to input formats, configure on the relevant format, and tick "smileys". Smileys should now show up in posts. I ahve not tested the smileys block or thing like that though.

wuf31’s picture

subscribing

Bartjuh’s picture

With ^^^

Would definitly love this module availible for 6.x!

Gurpartap Singh’s picture

Status: Needs work » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.