Responsive Image Styles

Welcome,

we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

ay13,

It seems this module aims to do the same thing as Responsive Images and Style (http://drupal.org/project/resp_img). It too uses image styles and allows you to use them based on screen width. The image styles can be vastly different as well.

The lazy loading of images is an interesting idea, but you may consider contributing a patch to a module that is already pretty mature and well supported.

jazzdrive3,

There are a number of architectural differences between our module and resp_img that makes ours more flexible.

With resp_img you can only set up one set of breakpoints that all responsive images use. Our module allows you to set up a set of breakpoints for each responsive image type. So you could have totally different breakpoints for different image fields. Now this can be a down side if you do want to use the same breakpoints for each image style, but that's something we can address prior to the 1.0 release. I can see that being a default list of breakpoints and a way to override them per responsive collection.

With resp_img you can't reuse image styles across responsive styles. With our module you select image style for the breakpoint not vice versa. This way you don't have duplicate your styles if you need to use the same one within a responsive style or between responsive styles.

We're not using image styles to store any information about the responsive styles, there are a set of DB tables inspired by the image_style tables that hold the collections and the breakpoint/image style associations. The only caveat to that is the quick dirty hack I put in to get the module to work with file styles where the responsive collections show up under the image_style list, but I'll be redoing that prior to the 1.0 release so that file styles is properly implemented.

I hope that clears up the differences.

--Andrew

Hello,

There is a displayed bug when I click on Delete button to delete a responsive groups entry and confirm it.

iptechlabs, thanks for spotting. It should be fixed now.

#5 suggest this is ready for another review.

There are some code styling issues, as well as files still in the master branch.

Details can be found at:

http://ventral.org/pareview/httpgitdrupalorgsandboxay131355098git

Regarding #3:

1. It's true, resp_img allows only one set of breakpoints to closely match how the css is handled with media queries.
2. Image styles aren't re-used, but there's an easy way to create all image styles at once for the whole set.

Regarding the overwrite of theme_image_style, this means that if somebody overwrites this in his theme, your module will stop working, better add it to the project page and/or README. You can have a look at the resp_img code to see how we handled it.

If you're interested we can still merge the 2 modules, meaning that we can add support for response.js to resp_img so people can choose one or the other.

Is this module similar to yours?

http://drupal.org/project/cs_adaptive_image

thank you

attiks,

I'm all for consolidating similar modules, but I do like the schema, admin UI structure and flexibility of ours. Is this something you'd be open to me adding to resp_img for a 2.0 release? Obviously that would be a big architectural change and an upgrade path would be needed.

I'm thinking about a configuration of a "base" set of breakpoints that the user can override per collection if they want. I think that's the best of both worlds.

MXT, It's similar but you are confined to a predefined number of breakpoints and you have to set them up per field instance, which seems pretty tedious.

andrew,

I like the idea of merging, but I'm wondering how you will handle inline content like an image inserted into the body of a node. I you want to try merging, clone resp_img into a sandbox to test it and create an issue in the resp_img issue queue so we can discuss this further.

attiks, that's a really valid point. We had only looked at this module from an image/file field perspective and not for inline images. That's going to take some thinking. Right now I can only see it working if we inject the responsive styles into the image style list and catch it before the theme function get's a hold of it, much like my dirty hack is doing for file styles. I'm open to other ideas.

I'll talk it over with ay13 about the option of trying to merge into resp_img

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Adding attribution to andrewko as a co-maintainer of this module