Bugfixes for input formats setting page

arte.mis - August 10, 2007 - 14:04
Project:Wordfilter
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

File: wordfilter.module
Function: wordfilter_filter()
Case: 'settings'

1.)
< '#description' => t('You can define a global list of words to be filtered on the <a href="%url">wordfilter settings page</a>.', array('%url' => url('admin/settings/wordfilter')))
---
> '#description' => t('You can define a global list of words to be filtered on the <a href="@url">wordfilter settings page</a>.', array('@url' => url('admin/settings/wordfilter')))

Replace %url by @url, otherwise the url is emphasized instead of run through check_plain.

2.)
< return drupal_get_form('wordfilter', $form);
---
> return $form;

Just return the $form because the callback function wordfilter() for rendering the form isn't defined in this module.

#1

budda - October 22, 2007 - 16:06
Priority:minor» normal
Status:active» reviewed & tested by the community

Anty chance that these small changes can be implemented in CVS and a 1.0 rolled out anytime soon? please?? :)

#2

singularo - October 29, 2007 - 05:15

Attaching a .patch file to help the maintainer get it committed ;-)

AttachmentSize
wordfilter_0.patch 800 bytes

#3

hunmonk - December 31, 2007 - 20:53

same basic patch, just more in line with the way fapi form elements are written.

AttachmentSize
wf_array_error.patch 1.19 KB

#4

hunmonk - January 1, 2008 - 17:38

should be !url, not %url...

AttachmentSize
wf_array_error.patch 1.19 KB

#5

add1sun - January 1, 2008 - 17:47
Status:reviewed & tested by the community» fixed

Committed to 5 and HEAD.

#6

Anonymous - January 15, 2008 - 17:51
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.