Are there any plans to make this module compatible with the Media module?
http://drupal.org/project/media

Thanks..

CommentFileSizeAuthor
#4 JAIL-media_integration-1662706-4.patch2.58 KBrerooting

Comments

svajlenka’s picture

svajlenka commented

While I had no immediate plans to implement media module compatibility, that does seem like a nice feature to have. I'm entirely unsure of how the implementation of that would look like/function. This is something I'd love to hear more from others and get built in.

remkovdz’s picture

remkovdz commented

I think it would give this module a lot more value, since there are tons of people using the media module.

I can't help you developing though...

rerooting’s picture

rerooting commented

This would be great!

Here is an example of how Galleria added media 7.x-2.x support:

http://drupalcode.org/project/galleria.git/commitdiff/3715479dbb5256e8ac...

Which layers on the existing support provided for 1.x:

http://drupalcode.org/project/galleria.git/blobdiff/9ae66fb9a4ec6ac97aa6...

rerooting’s picture

rerooting commented
StatusFileSize
new JAIL-media_integration-1662706-4.patch2.58 KB

Well, either I'm hallucinating or this actually works!

Make sure to clear the cache after applying this patch. I don't have time to test for a wide array of use cases, but this seems to work for file_entity image field formatters! You get the additional option of jail when you are in the mange file display options. It appears to work like a charm! Thanks for this awesome module!

(p.s. im not sure what the last part of the diff is doing but it didn't seem to have any negative impact on it)

justadropofwater’s picture

justadropofwater commented

This patch does work for images from Media. It's throwing some nasty notices:

Notice: Undefined index: alt in theme_jail_formatter() (line 177 of /Applications/MAMP/htdocs/sb/sites/all/modules/jail/jail.module).
Notice: Undefined index: title in theme_jail_formatter() (line 189 of /Applications/MAMP/htdocs/sb/sites/all/modules/jail/jail.module).

which is from images that don't have those attributes obviously. Is using drupal_strlen desirable way to determine if there is a title there? There isn't a check for 'alt'.

I'm going to take a look at getting other types of media working as well (which may be outside of the scope of jail since those are third-party api calls - maybe the mod author can give us some input).

rerooting’s picture

rerooting commented

Yeah apologies, I saw those and had to disable JAIL. It was a 'bonus' on this project and we had to keep moving. There are some other larger issues with this module, namely that it instantiates the same jquery function repeatedly for every image, causing a lot of issues with load time and flickering. I would be glad to help test any further patches you can provide for media integration, as I'm not much of a developer!

danlinn’s picture

danlinn commented
Status: Active » Needs work

@rerooting thanks for that note. That should be corrected.

We'll take a look at media integration as I'd love to see that project finally complete.