When I insert a video link from YouTube with the Video Filter Button in CKEditor, I get the following message:

"Strict warning: Only variables should be passed by reference in video_filter_dashboard_page() (line 387 of ...\sites\all\modules\video_filter\video_filter.module)."

Line 387 is the following:

print theme('video_filter_dashboard', array('form' => render(drupal_get_form('_video_filter_form'))));

I only have this problem on one site, on the other it never occured.

CommentFileSizeAuthor
#3 strict-warning-message-1662746-3.patch472 bytesbtopro

Comments

joel_osc’s picture

joel_osc commented

I am getting the same message...I think render requires a variable, so if you split it to lines as follows the message goes away:

$form = drupal_get_form('_video_filter_form');
print theme('video_filter_dashboard', array('form' => render($form)));
acranius’s picture

acranius commented
Status: Active » Closed (fixed)

Thanks, the module still works and the message doesn't appear anymore.
Setting status to closed (fixed).

btopro’s picture

btopro commented
Category: support » bug
Status: Closed (fixed) » Needs review
StatusFileSize
new strict-warning-message-1662746-3.patch472 bytes

Writing about a solution in a thread and marking it fixed without a patch seems a poor way of handling a current error. I'm still reproducing this in the latest version of drupal and latest version of module. Here's a patch of the solution above, which does work just think it should make it into the module.

smira’s picture

smira commented
Status: Needs review » Reviewed & tested by the community

clean patch fixes bug, please include in next release.
Thank you!

prston’s picture

prston commented
Version: 7.x-3.0 » 7.x-3.1
Status: Reviewed & tested by the community » Active

Patch provided on comment #3 was not included in further releases.
So, the strict warning always appear on 3.1 on line 435 (same file). Comment #1 still works on this line.

smira’s picture

smira commented
Priority: Normal » Major
Status: Active » Reviewed & tested by the community

switching status and priority hoping for commit

Yaron Tal’s picture

Yaron Tal commented
Version: 7.x-3.1 » 7.x-3.x-dev

Bump
Patch fixes strict warning for me as well. Still applies to dev version.
Only difference in the patch is that the line number increased by one.

ultimateboy’s picture

ultimateboy commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thanks all. Committed.

  • ultimateboy committed 9e6fe9b on 7.x-3.x 
    Issue #1662746 by btopro | acranius: Fixed Strict warning message.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

SuperTyp’s picture

SuperTyp commented

I still get this error in 7.31

Strict warning: Only variables should be passed by reference in video_filter_dashboard_page() (line 435 /sites/all/modules/video_filter/video_filter.module)

isn't it commited yet?

Northern_Girl’s picture

Northern_Girl commented

I got the exact same message as SuperTyp. What is the status on this?

Thanks.