Clean up css in Book

csslint: There are 1 problems in core/modules/book//book.admin.css.

book.admin.css
1: warning at line 10, col 1
Don't use IDs in selectors.
.js #edit-book-pick-book {


csslint: No errors in core/modules/book//book.theme-rtl.css.


csslint: No errors in core/modules/book//book.theme.css.

This is for .js :(

wait. this is different meaning.

core/modules/book/book.theme.css - pass
core/modules/book/book.theme-rtl.css - pass
core/modules/book/book.admin.css - 1 warning:
Don't use IDs in selectors.
.js #edit-book-pick-book {

I grep'd the codebase for 'edit-book-pick-book' and got no results.

this is the first patch by the Brighton Drupal Group by @guy_schneerson and @dixhuit hope it helps.
It replaces the id with a class selector for the book submit button on the edit page.
Please let us know if we missed out anything.

#4: clean_up_css_for_book-1662956-4.patch queued for re-testing.

OK, that looks like it's passed this time. Guy, what did you change or do differently?

@dixhuit the issue behind the issue Random test failures in SearchCommentTest its like a Fellini movie

Ahaaaah.

@guy_schneerson, @dixhuit - I looked at Random test failures in SearchCommentTest but I can't work out what problem is being described there.

What was the difference between the first patch you submitted for testing and the second one? The patch seems so simple that it's odd that it would cause a test failure.

@michaellenahan didn't change a thing, only pressed the Re-test.
the "random test" issue suggests that this error comes up randomly for no good reason, Re-testing made it go away

That is random failed tests. Do not need to care about it :)

#4 is passed now and for normal case, the patch looks good.

@droplet thanks, do you know what the next stage we tested it and it worked fine but do we need others to test before setting state to "Reviewed & tested"?

The patch in #4 applied cleanly and allowed the book outline form's submit button to continue to be hidden while utilizing a less-specific CSS selector.

The patch uses .book-outline-form (the nearest non-ID parent selector to the form's submit button) which is the best choice.

Thanks for the manual testing. Committed/pushed to 8.x.

This is changing css order priorities. imo, all these kind changes should not backport.